New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zoom controller improvements #9700

Merged
merged 4 commits into from Jun 14, 2017

Conversation

Projects
None yet
3 participants
@brenca
Member

brenca commented Jun 8, 2017

I've ported some code from the chromium zoom controller implementation to make the native PDF plugin work like it would in chromium - on zoom change only the document is zoomed, not the UI.

@brenca brenca requested review from zcbenz and deepak1556 Jun 8, 2017

@deepak1556

LGTM, with minor change. Thanks for this @brenca !

@@ -8,6 +8,9 @@
#include "base/bind.h"
#include "base/memory/ptr_util.h"
#include "base/values.h"
#include "content/public/browser/render_frame_host.h"
#include "content/public/browser/render_process_host.h"
#include "content/public/browser/render_view_host.h"

This comment has been minimized.

@deepak1556

deepak1556 Jun 10, 2017

Member

The headers are not used.

This comment has been minimized.

@brenca

brenca Jun 13, 2017

Member

Thanks for the catch! 🐟

@brenca

This comment has been minimized.

Member

brenca commented Jun 13, 2017

@zcbenz Could you take a look at this for me? 👀

@zcbenz

zcbenz approved these changes Jun 14, 2017

👍

@zcbenz zcbenz merged commit fd0a742 into electron:master Jun 14, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment