New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send window visibility to webview after DOM ready #9741

Merged
merged 3 commits into from Jun 14, 2017

Conversation

Projects
None yet
2 participants
@kevinsawicki
Contributor

kevinsawicki commented Jun 12, 2017

There seems to be a possible race condition where window-setup.js is loading and cannot receive IPC events and if the window changes visibility during that time, the <webview>'s document.visibilityState will be out of sync with the window.

This pull requests listens for dom-ready and sends the visibility state to the webview page then to make sure they are in sync.

Closes #9717

@poiru

This comment has been minimized.

Member

poiru commented Jun 12, 2017

Related: #8663

@kevinsawicki kevinsawicki merged commit 5b0290b into master Jun 14, 2017

6 of 9 checks passed

electron-win-ia32 Build #3412 failed in 10 min
Details
electron-win-x64 Build #3389 failed in 12 min
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
electron-linux-arm Build #6972229 succeeded in 83s
Details
electron-linux-ia32 Build #6972230 succeeded in 77s
Details
electron-linux-x64 Build #6972231 succeeded in 194s
Details
electron-mas-x64 Build #4437 succeeded in 9 min 15 sec
Details
electron-osx-x64 Build #4443 succeeded in 12 min
Details

@kevinsawicki kevinsawicki deleted the webview-visibility-state branch Jun 14, 2017

@kevinsawicki

This comment has been minimized.

Contributor

kevinsawicki commented Jun 14, 2017

Merging this for now, will pull it back out when the IPC redeliver issue is addressed via #6828

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment