New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mouse-enter and mouse-exit events for tray #9760

Merged
merged 4 commits into from Jun 28, 2017

Conversation

Projects
None yet
6 participants
@shubham2892
Contributor

shubham2892 commented Jun 14, 2017

Fixes #7616
Add API for listening to mouse-enter and mouse-exit events for Tray.

@shubham2892 shubham2892 changed the title from add mouse-enter and mouse-exit events for tray to Add mouse-enter and mouse-exit events for tray Jun 14, 2017

@zeke

This comment has been minimized.

Member

zeke commented Jun 14, 2017

Related to #8689

cc @pronebird

@pronebird

This comment has been minimized.

pronebird commented Jun 15, 2017

@zeke this PR introduces mouse hover support. That's different from when user clicks on other item in menubar...

@kevinsawicki

This comment has been minimized.

Contributor

kevinsawicki commented Jun 28, 2017

Thanks for this @shubham2892 👍

Pushed a few minor changes:

  • Renamed mouse-exit to mouse-leave to be consistent with the drag-leave event name on Tray. Can revisit in the 2.0 API if we want to switch from -leave to -exit.
  • Added the location and keyboard modifiers from the NSEvent to the emitted JavaScript event, similar to the right-click event.

@kevinsawicki kevinsawicki merged commit e44f655 into electron:master Jun 28, 2017

0 of 2 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
@zeke

This comment has been minimized.

Member

zeke commented Jun 28, 2017

🐭

@gclsoft

This comment has been minimized.

gclsoft commented Sep 24, 2018

https://electronjs.org/docs/api/tray#event-mouse-enter-macos
event-mouse-enter is works only on mac, not on Windows, right??

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment