New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add alwaysShowTitleTextInFullscreen flag #9788

Merged
merged 4 commits into from Jul 14, 2017

Conversation

Projects
None yet
5 participants
@shubham2892
Contributor

shubham2892 commented Jun 18, 2017

Fixes #8126
Add a flag alwaysShowTitleTextInFullscreen which enables to show title when titleBarStyle is set to hiddenInset. Default value is false.

Screenshot with flag enabled:
image

@poiru

This comment has been minimized.

Show comment
Hide comment
@poiru

poiru Jun 27, 2017

Member

FYI, this will be the default behavior after we switch to using the custom window buttons even for hiddenInset. The titlebar will also shrink to the normal size in fullscreen mode when we do that.

Member

poiru commented Jun 27, 2017

FYI, this will be the default behavior after we switch to using the custom window buttons even for hiddenInset. The titlebar will also shrink to the normal size in fullscreen mode when we do that.

@kevinsawicki kevinsawicki merged commit 5581d1d into electron:master Jul 14, 2017

0 of 2 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
@kevinsawicki

This comment has been minimized.

Show comment
Hide comment
@kevinsawicki

kevinsawicki Jul 14, 2017

Contributor

Thanks for this @shubham2892, works great 👍 🚀, pushed up one minor change to match the ivar name to the param name.

Contributor

kevinsawicki commented Jul 14, 2017

Thanks for this @shubham2892, works great 👍 🚀, pushed up one minor change to match the ivar name to the param name.

@astoilkov

This comment has been minimized.

Show comment
Hide comment
@astoilkov

astoilkov Jul 15, 2017

Contributor

One quick question - Why the buttons and the text are not aligned vertically in the screenshot?

Contributor

astoilkov commented Jul 15, 2017

One quick question - Why the buttons and the text are not aligned vertically in the screenshot?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment