New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix invisible titlebar on macOS 10.13 #9798

Merged
merged 1 commit into from Jun 22, 2017

Conversation

Projects
None yet
2 participants
@tonyganch
Member

tonyganch commented Jun 19, 2017

Should fix #9711.
From https://developer.apple.com/library/content/releasenotes/AppKit/RN-AppKit/index.html:

Previously NSWindow would make the titlebar transparent for certain windows with NSWindowStyleMaskTexturedBackground set, even if titlebarAppearsTransparent was NO. When linking against the 10.13 SDK, textured windows must explicitly set titlebarAppearsTransparent to YES for this behavior.

I checked the behaviour on 10.12 and 10.13.
Are there any possible downsides on 10.12 i don't see?

/cc @poiru

@poiru

This comment has been minimized.

Member

poiru commented Jun 22, 2017

Any chance you could check if High Sierra Beta 2 fixes this? (See #9711 (comment).)

@tonyganch

This comment has been minimized.

Member

tonyganch commented Jun 22, 2017

@poiru, sure, will check first thing tomorrow

@tonyganch

This comment has been minimized.

Member

tonyganch commented Jun 22, 2017

@poiru, it seems to work but i get in console:

*** WARNING: Textured window <AtomNSWindow: 0x7fee63ca9c40> is getting an implicitly transparent titlebar. This will break when linking against newer SDKs. Use NSWindow's -titlebarAppearsTransparent=YES instead.
@poiru

poiru approved these changes Jun 22, 2017

Thanks for checking!

@poiru poiru merged commit 3cc0429 into master Jun 22, 2017

5 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
electron-mas-x64 Build #4456 succeeded in 11 min
Details
electron-osx-x64 Build #4461 succeeded in 10 min
Details
electron-win-ia32 Build #3431 succeeded in 12 min
Details

@poiru poiru deleted the tonyganch/10.13-transparent-titlebar branch Jun 22, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment