New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix treat packaged app as directory #9834

Merged
merged 4 commits into from Jul 18, 2017

Conversation

Projects
None yet
3 participants
@shubham2892
Copy link
Contributor

shubham2892 commented Jun 22, 2017

Fixes #8948
Added the flag that enables treating file packages as directories.

@@ -93,6 +93,7 @@ void SetupDialog(NSSavePanel* dialog,

void SetupDialogForProperties(NSOpenPanel* dialog, int properties) {
[dialog setCanChooseFiles:(properties & FILE_DIALOG_OPEN_FILE)];
[dialog setTreatsFilePackagesAsDirectories:YES];

This comment has been minimized.

@kevinsawicki

kevinsawicki Jul 14, 2017

Contributor

@shubham2892 what do you think about making this an option instead of always on? Similar to how setResolveAliases support was added in #8617.

This comment has been minimized.

@shubham2892

shubham2892 Jul 18, 2017

Author Contributor

Yes adding the option instead of making it mandatory would be better. Made the changes.

@kevinsawicki kevinsawicki force-pushed the shubham2892:input-type-file-treating-packaged-app-as-directory branch from d85a802 to b25a1d1 Jul 18, 2017

kevinsawicki added some commits Jul 18, 2017

@kevinsawicki

This comment has been minimized.

Copy link
Contributor

kevinsawicki commented Jul 18, 2017

Thanks for this @shubham2892 👍 🍎 🍏

@kevinsawicki kevinsawicki merged commit 959231f into electron:master Jul 18, 2017

0 of 2 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment