Fix treat packaged app as directory #9834
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atom/browser/ui/file_dialog_mac.mm
Outdated
| @@ -93,6 +93,7 @@ void SetupDialog(NSSavePanel* dialog, | |||
|
|
|||
| void SetupDialogForProperties(NSOpenPanel* dialog, int properties) { | |||
| [dialog setCanChooseFiles:(properties & FILE_DIALOG_OPEN_FILE)]; | |||
| [dialog setTreatsFilePackagesAsDirectories:YES]; | |||
There was a problem hiding this comment.
@shubham2892 what do you think about making this an option instead of always on? Similar to how setResolveAliases support was added in #8617.
There was a problem hiding this comment.
Yes adding the option instead of making it mandatory would be better. Made the changes.
kevinsawicki
force-pushed
the
input-type-file-treating-packaged-app-as-directory
branch
from
d85a802
to
b25a1d1
Compare
|
Thanks for this @shubham2892 👍 🍎 🍏 |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8948
Added the flag that enables treating file packages as directories.