New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix page's URL used to test against content_scripts[].matches #9953

Merged
merged 2 commits into from Jul 14, 2017

Conversation

Projects
None yet
3 participants
@alexstrat
Contributor

alexstrat commented Jul 7, 2017

content_scripts[].matches are tested against page URL without fragment part.

@kevinsawicki kevinsawicki merged commit 03c8943 into electron:master Jul 14, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@kevinsawicki

This comment has been minimized.

Show comment
Hide comment
@kevinsawicki

kevinsawicki Jul 14, 2017

Contributor

Thanks for fixing this @alexstrat 👍 🚀

Contributor

kevinsawicki commented Jul 14, 2017

Thanks for fixing this @alexstrat 👍 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment