New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #8768: Show() on already open modal #9962

Merged
merged 1 commit into from Jul 17, 2017

Conversation

Projects
None yet
2 participants
@ferreus
Contributor

ferreus commented Jul 9, 2017

Calling show() on an already open modal causes the parent to become unusable

Because SetEnabled tracks number of calls and re-enables the window only when counter is back to 0,
Calling Show() on already visible window would prevent the modal lock to be released when modal is closed. This PR fixes it, by calling SetEnabled only when window is invisible. Preventing duplicate calls to SetEnabled.

Fix #8768: Show() on already open modal
Calling show() on an already open modal causes the parent to become unusable
@zcbenz

zcbenz approved these changes Jul 17, 2017

👍

@zcbenz zcbenz merged commit a43553a into electron:master Jul 17, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment