Fix devtools open in mixed sandbox #9983
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juturu
force-pushed
the
devtools-mixed-sandbox
branch
from
6517691
to
80bd6a3
Compare
|
I'm not familiar with the mixed sandbox code enough to review the actual code changes - as for the tests, is the My experience with 1.7.4 was that BrowserWindow indicated that the devTools were opened when they actually weren't, so I'm just wary that the event would fire anyway even if the devtools were broken. Apart from these concerns, lgtm 👍 Thanks for addressing this! 🌟 |
Yes. Same event is used to test other devtools tests.
Yes. Without the fix, this new test fails. |
kevinsawicki
approved these changes
Jul 14, 2017
|
Thanks @kevinsawicki 🙇 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing devtools open in mixed sandbox. Added UTs to validate.
cc: @fasterthanlime @chandrachivukula