New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to node 8.2.1 #9992

Merged
merged 5 commits into from Jul 31, 2017

Conversation

Projects
None yet
3 participants
@kevinsawicki
Copy link
Contributor

kevinsawicki commented Jul 12, 2017

Pull request to upgrade the chrome 59 pull request to Node 8.2.1 (from 7.9).

Node patches applied against 8.2.1 via electron/node#23

Fixes #9970

@kevinsawicki kevinsawicki changed the title Upgrade to node 8.2.0 Upgrade to node 8.1.4 Jul 13, 2017

@kevinsawicki

This comment has been minimized.

Copy link
Contributor

kevinsawicki commented Jul 13, 2017

Switched to node 8.1.4 instead since the 8.2 release hasn't happened yet and may or may not be against v8 6.0

@kevinsawicki kevinsawicki force-pushed the upgrade-to-node-8-2 branch from 2d64960 to 7f2355e Jul 14, 2017

@alexeykuzmin alexeykuzmin force-pushed the upgrade-to-chromium-59 branch from 8e9eb3b to 256fc6a Jul 17, 2017

@alexeykuzmin

This comment has been minimized.

Copy link
Contributor

alexeykuzmin commented Jul 22, 2017

Btw, Node.js v8.2.1 has already been released (with V8 5.8.283.41).

Is it ok that we will end up with V8 v5.9 in libcc and V8 v5.8 in Node?

@zcbenz

This comment has been minimized.

Copy link
Contributor

zcbenz commented Jul 24, 2017

Is it ok that we will end up with V8 v5.9 in libcc and V8 v5.8 in Node?

Yeah, Electron updates V8 much more frequently than Node, so it is uncommon do they use the same V8.

@alexeykuzmin alexeykuzmin force-pushed the upgrade-to-chromium-59 branch 2 times, most recently from 1179137 to e149418 Jul 24, 2017

@zcbenz zcbenz force-pushed the upgrade-to-chromium-59 branch 2 times, most recently from 7a19226 to 3c5dd36 Jul 31, 2017

@kevinsawicki kevinsawicki force-pushed the upgrade-to-node-8-2 branch from 7f2355e to a68a40f Jul 31, 2017

@kevinsawicki kevinsawicki changed the title Upgrade to node 8.1.4 Upgrade to node 8.2.1 Jul 31, 2017

@kevinsawicki kevinsawicki merged commit f4ce5b2 into upgrade-to-chromium-59 Jul 31, 2017

4 of 6 checks passed

electron-linux-x64 Build #7475591 failed in 1796s
Details
electron-win-x64 Build #3699 in progress...
Details
electron-linux-arm Build #7475589 succeeded in 175s
Details
electron-linux-ia32 Build #7475590 succeeded in 176s
Details
electron-mas-x64 Build #4708 succeeded in 14 min
Details
electron-osx-x64 Build #4711 succeeded in 14 min
Details

@kevinsawicki kevinsawicki deleted the upgrade-to-node-8-2 branch Jul 31, 2017

@kevinsawicki kevinsawicki referenced this pull request Jul 31, 2017

Merged

Upgrade to Chromium 59 #9946

2 of 2 tasks complete

@zeke zeke referenced this pull request Aug 22, 2017

Merged

bump @types/node to 8 #10328

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment