From 051026da1359167e12fde886c212ea639af14f99 Mon Sep 17 00:00:00 2001 From: Rodion Borisov Date: Fri, 20 Jul 2018 07:37:40 +0300 Subject: [PATCH] fix(core): append current version to each sibling dependency of `@electron-forge` in the boilerplate (#537) * Fixing #535 * Append current version to devDependencies (#534) * Helper function for sibling dependency installation string https://github.com/electron-userland/electron-forge/pull/537#discussion_r202338217 * Reading version from core's `package.json` manually --- .../api/core/src/api/init-scripts/init-npm.ts | 15 ++++++++++----- 1 file changed, 10 insertions(+), 5 deletions(-) diff --git a/packages/api/core/src/api/init-scripts/init-npm.ts b/packages/api/core/src/api/init-scripts/init-npm.ts index 8208605ddc..51b6c19cb9 100644 --- a/packages/api/core/src/api/init-scripts/init-npm.ts +++ b/packages/api/core/src/api/init-scripts/init-npm.ts @@ -9,14 +9,19 @@ import installDepList from '../../util/install-dependencies'; import { readRawPackageJson } from '../../util/read-package-json'; const d = debug('electron-forge:init:npm'); +const corePackage = fs.readJsonSync(path.resolve(__dirname, '../../../package.json')); + +function siblingDep(name: string) { + return `@electron-forge/${name}@${corePackage.version}`; +} export const deps = ['electron-squirrel-startup']; export const devDeps = [ - '@electron-forge/cli', - '@electron-forge/maker-squirrel', - '@electron-forge/maker-zip', - '@electron-forge/maker-deb', - '@electron-forge/maker-rpm', + siblingDep('cli'), + siblingDep('maker-squirrel'), + siblingDep('maker-zip'), + siblingDep('maker-deb'), + siblingDep('maker-rpm'), ]; export const exactDevDeps = ['electron'];