From b4f6dd9f8da7ba63099e4b802c59d1f56feca0cc Mon Sep 17 00:00:00 2001
From: Samuel Attard <sam@electronjs.org>
Date: Thu, 9 Nov 2023 10:48:46 -0800
Subject: [PATCH] fix: handle missing manifest in zip maker (#3405)

---
 packages/maker/zip/src/MakerZIP.ts       |  4 +++-
 packages/maker/zip/test/MakerZip_spec.ts | 24 ++++++++++++++++++++++++
 2 files changed, 27 insertions(+), 1 deletion(-)

diff --git a/packages/maker/zip/src/MakerZIP.ts b/packages/maker/zip/src/MakerZIP.ts
index 34e06b59a2..0772ebdece 100644
--- a/packages/maker/zip/src/MakerZIP.ts
+++ b/packages/maker/zip/src/MakerZIP.ts
@@ -48,7 +48,9 @@ export default class MakerZIP extends MakerBase<MakerZIPConfig> {
     if (targetPlatform === 'darwin' && this.config.macUpdateManifestBaseUrl) {
       const parsed = new URL(this.config.macUpdateManifestBaseUrl);
       parsed.pathname += '/RELEASES.json';
-      const response = await got.get(parsed.toString());
+      const response = await got.get(parsed.toString(), {
+        throwHttpErrors: false,
+      });
       let currentValue: SquirrelMacReleases = {
         currentRelease: '',
         releases: [],
diff --git a/packages/maker/zip/test/MakerZip_spec.ts b/packages/maker/zip/test/MakerZip_spec.ts
index 54cb96cf4d..17f8073e38 100644
--- a/packages/maker/zip/test/MakerZip_spec.ts
+++ b/packages/maker/zip/test/MakerZip_spec.ts
@@ -143,6 +143,30 @@ describe('MakerZip', () => {
         expect(foo.releases[0].updateTo).to.have.property('url');
       });
 
+      it('should generate a valid RELEASES.json manifest with no current file', async () => {
+        maker.config = {
+          macUpdateManifestBaseUrl: 'fake://test/foo',
+        };
+        getStub.returns(Promise.resolve({ statusCode: 404, body: 'GARBAGE' }));
+        const output = await maker.make({
+          dir: darwinDir,
+          makeDir,
+          appName,
+          targetArch,
+          targetPlatform: 'darwin',
+          packageJSON,
+          forgeConfig: null as any,
+        });
+
+        const foo = await fs.readJson(output[1]);
+        expect(foo).to.have.property('currentRelease', '1.2.3');
+        expect(foo).to.have.property('releases');
+        expect(foo.releases).to.be.an('array').with.lengthOf(1);
+        expect(foo.releases[0]).to.have.property('version');
+        expect(foo.releases[0]).to.have.property('updateTo');
+        expect(foo.releases[0].updateTo).to.have.property('url');
+      });
+
       it('should extend the current RELEASES.json manifest if it exists', async () => {
         maker.config = {
           macUpdateManifestBaseUrl: 'fake://test/foo',