From f42c962aead0897a97732fa8f525a7fdba38400a Mon Sep 17 00:00:00 2001
From: Mark Lee <malept@users.noreply.github.com>
Date: Fri, 23 Jul 2021 10:35:19 -0700
Subject: [PATCH] fix(template): add plugin:import/electron to TypeScript
 ESLint config (#2399)

* chore(template-typescript-webpack): remove superfluous resolver config
* refactor(template): use import/recommended over errors+warnings
* chore(template-typescript-webpack): add test script
---
 .../template/typescript-webpack/package.json   |  2 +-
 .../typescript-webpack/tmpl/.eslintrc.json     | 18 +++---------------
 .../template/typescript/tmpl/.eslintrc.json    |  4 ++--
 3 files changed, 6 insertions(+), 18 deletions(-)

diff --git a/packages/template/typescript-webpack/package.json b/packages/template/typescript-webpack/package.json
index d98ae56769..b7c389464a 100644
--- a/packages/template/typescript-webpack/package.json
+++ b/packages/template/typescript-webpack/package.json
@@ -8,7 +8,7 @@
   "main": "dist/TypeScriptWebpackTemplate.js",
   "typings": "dist/TypeScriptWebpackTemplate.d.ts",
   "scripts": {
-    "test": "echo No Tests"
+    "test": "mocha --config ../../../.mocharc.js test/**/*_spec.ts"
   },
   "engines": {
     "node": ">= 12.13.0"
diff --git a/packages/template/typescript-webpack/tmpl/.eslintrc.json b/packages/template/typescript-webpack/tmpl/.eslintrc.json
index cc554ebc34..2d7aa60744 100644
--- a/packages/template/typescript-webpack/tmpl/.eslintrc.json
+++ b/packages/template/typescript-webpack/tmpl/.eslintrc.json
@@ -8,21 +8,9 @@
     "eslint:recommended",
     "plugin:@typescript-eslint/eslint-recommended",
     "plugin:@typescript-eslint/recommended",
-    "plugin:import/errors",
-    "plugin:import/warnings",
+    "plugin:import/recommended",
+    "plugin:import/electron",
     "plugin:import/typescript"
   ],
-  "parser": "@typescript-eslint/parser",
-  "settings": {
-    "import/resolver": {
-      "node": {
-        "extensions": [
-          ".js",
-          ".jsx",
-          ".ts",
-          ".tsx"
-        ]
-      }
-    }
-  }
+  "parser": "@typescript-eslint/parser"
 }
diff --git a/packages/template/typescript/tmpl/.eslintrc.json b/packages/template/typescript/tmpl/.eslintrc.json
index 970228353f..7017aad68c 100644
--- a/packages/template/typescript/tmpl/.eslintrc.json
+++ b/packages/template/typescript/tmpl/.eslintrc.json
@@ -8,8 +8,8 @@
       "eslint:recommended",
       "plugin:@typescript-eslint/eslint-recommended",
       "plugin:@typescript-eslint/recommended",
-      "plugin:import/errors",
-      "plugin:import/warnings",
+      "plugin:import/recommended",
+      "plugin:import/electron",
       "plugin:import/typescript"
     ],
     "parser": "@typescript-eslint/parser"