Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Make autoUpdate and autoLaunch features configurable in MakerWixConfig #2620

Merged
merged 1 commit into from
Feb 11, 2022

Conversation

pthompson-asana
Copy link
Contributor

  • I have read the contribution documentation for this project.
  • I agree to follow the code of conduct that this project follows, as appropriate.
  • The changes are appropriately documented (if applicable).
  • The changes have sufficient test coverage (if applicable).
  • The testsuite passes successfully on my local machine (if applicable).

Summarize your changes:
feat: Make autoUpdate and autoLaunch features configurable in MakerWixConfig

  • Added features property to MakerWixConfig to enable configuration of autoUpdate and autoLaunch features
    • (see electron-wix-msi's Features definition here)
  • These features can then be configured by adding features to @electron-forge/maker-wix's config in forge.config.js
  • Example: features: { autoUpdate: true, autoLaunch: false }

…xConfig

feat: Make autoUpdate and autoLaunch features configurable in MakerWixConfig
- Added 'features' property to `MakerWixConfig` to enable configuration of `autoUpdate` and `autoLaunch` features
     - (see definition [here](https://github.com/felixrieseberg/electron-wix-msi/blob/master/src/creator.ts#L85))
- These features can then be configured by adding `features` to `@electron-forge/maker-wix`'s `config` in `forge.config.js`
Example:
```
features: { autoUpdate: true, autoLaunch: false }
```
@pthompson-asana
Copy link
Contributor Author

@MarshallOfSound and @malept Is this the correct way to submit a PR to the repository? The option to add reviewers is disabled for me so I'm tagging you here to take a look. Thank you!

@codecov
Copy link

codecov bot commented Dec 6, 2021

Codecov Report

Merging #2620 (783b9a9) into master (c057485) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2620   +/-   ##
=======================================
  Coverage   56.59%   56.59%           
=======================================
  Files          74       74           
  Lines        2668     2668           
  Branches      669      669           
=======================================
  Hits         1510     1510           
+ Misses       1017     1014    -3     
- Partials      141      144    +3     
Impacted Files Coverage Δ
packages/api/core/src/api/lint.ts 25.00% <0.00%> (ø)
packages/api/core/src/api/import.ts 14.28% <0.00%> (ø)
packages/api/core/src/api/package.ts 17.39% <0.00%> (ø)
packages/api/core/src/util/forge-config.ts 58.76% <0.00%> (ø)
packages/api/core/src/util/plugin-interface.ts 28.07% <0.00%> (ø)
packages/installer/darwin/src/InstallerDarwin.ts 35.00% <0.00%> (ø)
...ges/api/core/src/api/init-scripts/find-template.ts 22.22% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c057485...783b9a9. Read the comment docs.

@pthompson-asana
Copy link
Contributor Author

@MarshallOfSound @malept I see that the slow-tests for ubuntu are failing repeatedly, but as someone pointed out in the Electron HQ Slack thread, these tests are also failing on master. Can this PR be merged then since the test issue is not caused by this PR? Thanks!

Copy link
Member

@malept malept left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems fine, although I really don't want to keep a mirror of the options from electron-wix-msi. Eventually I want to just do something like:

import { MSICreatorOptions } from 'electron-wix-msi';

export MakerWixConfig = Omit<MSICreatorOptions, 'something' | 'somethingElse' | 'etc'>;

@malept malept merged commit bf7d271 into electron:master Feb 11, 2022
@malept
Copy link
Member

malept commented Feb 11, 2022

Ah, I missed this. In the future the PR title should look something like

feat(maker-wix-msi): add features to config

@pthompson-asana
Copy link
Contributor Author

Gotcha. Thank you Mark!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants