-
-
Notifications
You must be signed in to change notification settings - Fork 507
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Make autoUpdate and autoLaunch features configurable in MakerWixConfig #2620
Conversation
…xConfig feat: Make autoUpdate and autoLaunch features configurable in MakerWixConfig - Added 'features' property to `MakerWixConfig` to enable configuration of `autoUpdate` and `autoLaunch` features - (see definition [here](https://github.com/felixrieseberg/electron-wix-msi/blob/master/src/creator.ts#L85)) - These features can then be configured by adding `features` to `@electron-forge/maker-wix`'s `config` in `forge.config.js` Example: ``` features: { autoUpdate: true, autoLaunch: false } ```
@MarshallOfSound and @malept Is this the correct way to submit a PR to the repository? The option to add reviewers is disabled for me so I'm tagging you here to take a look. Thank you! |
Codecov Report
@@ Coverage Diff @@
## master #2620 +/- ##
=======================================
Coverage 56.59% 56.59%
=======================================
Files 74 74
Lines 2668 2668
Branches 669 669
=======================================
Hits 1510 1510
+ Misses 1017 1014 -3
- Partials 141 144 +3
Continue to review full report at Codecov.
|
@MarshallOfSound @malept I see that the slow-tests for ubuntu are failing repeatedly, but as someone pointed out in the Electron HQ Slack thread, these tests are also failing on |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems fine, although I really don't want to keep a mirror of the options from electron-wix-msi
. Eventually I want to just do something like:
import { MSICreatorOptions } from 'electron-wix-msi';
export MakerWixConfig = Omit<MSICreatorOptions, 'something' | 'somethingElse' | 'etc'>;
Ah, I missed this. In the future the PR title should look something like
|
Gotcha. Thank you Mark! |
Summarize your changes:
feat: Make autoUpdate and autoLaunch features configurable in MakerWixConfig
features
property toMakerWixConfig
to enable configuration ofautoUpdate
andautoLaunch
featureselectron-wix-msi
'sFeatures
definition here)features
to@electron-forge/maker-wix
'sconfig
inforge.config.js
features: { autoUpdate: true, autoLaunch: false }