Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

home-path is not consistent across drives in Windows #7

Closed
fritx opened this issue Sep 24, 2015 · 5 comments
Closed

home-path is not consistent across drives in Windows #7

fritx opened this issue Sep 24, 2015 · 5 comments
Labels
help wanted Extra attention is needed

Comments

@fritx
Copy link
Contributor

fritx commented Sep 24, 2015

The home-path doesn't add HOMEDRIVE to the HOMEPATH, so the absolute path \\Users\\fritz.lin isn't consistent across different Windows drives like C:, D:, etc. It isn't the actual reliable homepath either. I'd recommend using user-home instead :)

Related: 75lb/home-path#2, egoist/nwjs#4
@max-mapper max-mapper added the help wanted Extra attention is needed label Sep 24, 2015
@max-mapper
Copy link
Contributor

added a help wanted label in case any windows devs wanna make a PR and test it on windows

@75lb
Copy link

75lb commented Sep 25, 2015

fixed and released in version 1.0.1 of home-path.. please reinstall / update electron-download and try again @fritx

@fritx fritx closed this as completed in 7616105 Sep 25, 2015
@fritx
Copy link
Contributor Author

fritx commented Sep 25, 2015

nice, tested under Windows

@fritx
Copy link
Contributor Author

fritx commented Sep 25, 2015

@maxogden let's your time to bump a version ;)

@fritx
Copy link
Contributor Author

fritx commented Oct 7, 2015

published in 1.2.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@max-mapper @75lb @fritx