Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add an option to remove / use the 'v' prefix when normalizing the version #134

Open
wants to merge 1 commit into
base: master
from

Conversation

@MarshallOfSound
Copy link
Member

MarshallOfSound commented Nov 29, 2019

Closes #123
Closes #120

…he version
@MarshallOfSound MarshallOfSound requested a review from malept Nov 29, 2019
@nickfan

This comment has been minimized.

Copy link

nickfan commented Nov 29, 2019

Closes #123
Closes #120

the problem is the normalizeVersion apply to the custom_dir and filename part of the download URL.

but for taobao mirror it only use verion number without 'v' prefix for the custom_dir part but not for the file name part.

in 7.0.0
https://npm.taobao.org/mirrors/electron/v7.0.0/electron-v7.0.0-darwin-x64.zip
in 6.1.2
https://npm.taobao.org/mirrors/electron/6.1.2/electron-v6.1.2-darwin-x64.zip

electron-v6.1.2-darwin-x64.zip
and /6.1.2/ in the dir part.

so for 7.0.0
electron-v7.0.0-darwin-x64.zip
and /7.0.0/ in the dir part.

i think maybe split ELECTRON_GET_NO_V_PREFIX into

ELECTRON_GET_NO_V_PREFIX_CUSTOM_DIR

ELECTRON_GET_NO_V_PREFIX_FILENAME

may solve the problem.

@MarshallOfSound

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.