New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Chrome 54 #239

Closed
wants to merge 86 commits into
base: master
from

Conversation

Projects
None yet
6 participants
@zcbenz
Contributor

zcbenz commented Nov 2, 2016

  • Switch to gn
  • Update all the patches
  • Compile on Linux
  • Compile on OS X
  • Compile on Windows
  • Generate distributions on Linux
  • Generate distributions on OS X
  • Generate distributions on Windows
  • Check how to make widevine compile
  • Check everything works with Electron
@kevinsawicki

This comment has been minimized.

Show comment
Hide comment
@kevinsawicki

kevinsawicki Dec 2, 2016

Contributor

Hey @zcbenz, there was an issue on our Linux CI where the logs were too long because of an assertion that was getting logged thousands of times. I fixed it on master in #246 so you may want to rebase/merge that into here to get the libchromiumcontent-linux build working.

Contributor

kevinsawicki commented Dec 2, 2016

Hey @zcbenz, there was an issue on our Linux CI where the logs were too long because of an assertion that was getting logged thousands of times. I fixed it on master in #246 so you may want to rebase/merge that into here to get the libchromiumcontent-linux build working.

Show outdated Hide outdated script/update
@demian85

This comment has been minimized.

Show comment
Hide comment
@demian85

demian85 Jan 9, 2017

Contributor

Is it safe to build using this branch? #252

Contributor

demian85 commented Jan 9, 2017

Is it safe to build using this branch? #252

@kevinsawicki

This comment has been minimized.

Show comment
Hide comment
@kevinsawicki

kevinsawicki Jan 9, 2017

Contributor

Is it safe to build using this branch?

This branch will (most likely) be merged and released this month in Electron 1.5.0, but there will be releases before that done from master and released as Electron 1.4.x.

So if it is easier to do what you are trying to do against Chrome 54 and that timeline works for you then building against this branch is fine.

Contributor

kevinsawicki commented Jan 9, 2017

Is it safe to build using this branch?

This branch will (most likely) be merged and released this month in Electron 1.5.0, but there will be releases before that done from master and released as Electron 1.4.x.

So if it is easier to do what you are trying to do against Chrome 54 and that timeline works for you then building against this branch is fine.

@zcbenz

This comment has been minimized.

Show comment
Hide comment
@zcbenz

zcbenz Jan 17, 2017

Contributor

Closed in favor of #254.

Contributor

zcbenz commented Jan 17, 2017

Closed in favor of #254.

@zcbenz zcbenz closed this Jan 17, 2017

@zcbenz zcbenz deleted the chrome54 branch Jan 17, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment