New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Include v8 context snapshot generator #697

Merged
merged 12 commits into from Oct 26, 2018

Conversation

Projects
None yet
2 participants
@jkleinsc
Contributor

jkleinsc commented Oct 25, 2018

Description of Change

Starting with 3-0-x, when creating custom snapshots via mksnapshot an additional binary v8_context_snapshot_generator needs to be run in order to generate the file v8_context_snapshot.bin which is needed in order to apply the custom snapshot. This PR adds that binary to our libcc builds.

Checklist
  • PR description included and stakeholders cc'd
  • Patch information is added to appropriate .patches.yaml
  • script/update runs without error
  • PR title follows semantic commit guidelines
@ckerr

ckerr approved these changes Oct 26, 2018

@ckerr ckerr merged commit d2c3189 into electron-3-0-x Oct 26, 2018

19 checks passed

Semantic Pull Request ready to be squashed
Details
WIP ready for review
Details
appveyor: libchromiumcontent-ia32-shared AppVeyor build succeeded
Details
appveyor: libchromiumcontent-ia32-static AppVeyor build succeeded
Details
appveyor: libchromiumcontent-x64-shared AppVeyor build succeeded
Details
appveyor: libchromiumcontent-x64-static AppVeyor build succeeded
Details
ci/circleci: libchromiumcontent-linux-arm-shared Your tests passed on CircleCI!
Details
ci/circleci: libchromiumcontent-linux-arm-static Your tests passed on CircleCI!
Details
ci/circleci: libchromiumcontent-linux-arm64-shared Your tests passed on CircleCI!
Details
ci/circleci: libchromiumcontent-linux-arm64-static Your tests passed on CircleCI!
Details
ci/circleci: libchromiumcontent-linux-ia32-shared Your tests passed on CircleCI!
Details
ci/circleci: libchromiumcontent-linux-ia32-static Your tests passed on CircleCI!
Details
ci/circleci: libchromiumcontent-linux-x64-shared Your tests passed on CircleCI!
Details
ci/circleci: libchromiumcontent-linux-x64-static Your tests passed on CircleCI!
Details
libchromiumcontent-mas-shared-branch #20181025.3 succeeded
Details
libchromiumcontent-mas-static-branch #20181025.3 succeeded
Details
libchromiumcontent-mas-static-pr #20181025.4 succeeded
Details
libchromiumcontent-osx-shared-branch #20181025.3 succeeded
Details
libchromiumcontent-osx-static-branch #20181025.3 succeeded
Details

@ckerr ckerr deleted the include-v8-context-snapshot-generator branch Oct 26, 2018

@jkleinsc jkleinsc restored the include-v8-context-snapshot-generator branch Oct 29, 2018

@jkleinsc jkleinsc deleted the include-v8-context-snapshot-generator branch Oct 30, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment