New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not build libchromiumcontent as a single shared library #98

Merged
merged 48 commits into from Apr 11, 2015

Conversation

Projects
None yet
2 participants
@zcbenz
Contributor

zcbenz commented Apr 3, 2015

This PR makes libchromiumcontent build with 2 versions: one is shared_library mode, which is the "component build" in Chromium and consists lots of small shared libraries; the other is static_library mode, which consists static libraries that can be linked to the final binary.

The shared_library version is used for development, which links very fast but in sacrifice of size and performance. And the static_library version is used for release, it generates the binary with smallest size and maximum optimization, but in the price of extremely long link time.

In atom-shell, we will use shared_library version in Debug build, and use static_library version in Release build.

This also enables 64bit build on Windows.

zcbenz added a commit that referenced this pull request Apr 11, 2015

Merge pull request #98 from atom/component_build
Do not build libchromiumcontent as a single shared library

@zcbenz zcbenz merged commit 7bef351 into master Apr 11, 2015

2 of 3 checks passed

libchromiumcontent-win Build #1988018 failed in 82s
Details
libchromiumcontent-linux Build #1988016 succeeded in 220s
Details
libchromiumcontent-osx Build #1988017 succeeded in 659s
Details

@zcbenz zcbenz deleted the component_build branch Apr 11, 2015

@aroben

This comment has been minimized.

Show comment
Hide comment
@aroben

aroben Apr 13, 2015

Contributor

Yay! Thanks for making this happen.

Contributor

aroben commented Apr 13, 2015

Yay! Thanks for making this happen.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment