Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bs4 is beautifulsoup4 #331

Closed
wants to merge 1 commit into from

Conversation

@jakirkham
Copy link

@jakirkham jakirkham commented Jun 5, 2018

Replace bs4 with beautifulsoup4 as they are the same and the former is merely an alias.


This change is Reviewable

@jakirkham jakirkham force-pushed the use_beautifulsoup4 branch from e9d6cb0 to 05e971f Jun 5, 2018
@jni
Copy link
Collaborator

@jni jni commented Jun 5, 2018

Thanks @jakirkham! Having you contribute here makes me very happy. =)

@jni
Copy link
Collaborator

@jni jni commented Jun 5, 2018

Hmmm though actually the wercker build crashed, and appears to be related... Do we need to pin a version somewhere?

@jakirkham jakirkham force-pushed the use_beautifulsoup4 branch from 05e971f to 8f3de9d Jun 5, 2018
Replace `bs4` with `beautifulsoup4` as they are the same and the former
is merely an alias.
@jakirkham jakirkham force-pushed the use_beautifulsoup4 branch from 8f3de9d to e17c1fe Jun 5, 2018
@jni
Copy link
Collaborator

@jni jni commented Jun 5, 2018

Hmmm this is strange. @stefanv might have some insights...

@jni jni mentioned this pull request Jun 5, 2018
@jakirkham
Copy link
Author

@jakirkham jakirkham commented Jun 5, 2018

Was thinking BeautifulSoup4 4.6.0 was causing the issue, but pinning doesn't seem to help. 😕

ref: https://app.wercker.com/elegant-scipy/elegant-scipy/runs/build/5b1626341af74e00013eb7b7?step=5b16265aa916600001137d74

@stefanv
Copy link
Collaborator

@stefanv stefanv commented Jun 5, 2018

@jni
Copy link
Collaborator

@jni jni commented Jun 5, 2018

Hmm, this is concerning, to say the least! I guess I vote for merging this anyway in that case...!

@jni jni closed this in 3192c3b Nov 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants