Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign up`bs4` is `beautifulsoup4` #331
Closed
Conversation
This comment has been minimized.
This comment has been minimized.
Thanks @jakirkham! Having you contribute here makes me very happy. =) |
This comment has been minimized.
This comment has been minimized.
Hmmm though actually the wercker build crashed, and appears to be related... Do we need to pin a version somewhere? |
Replace `bs4` with `beautifulsoup4` as they are the same and the former is merely an alias.
This comment has been minimized.
This comment has been minimized.
Hmmm this is strange. @stefanv might have some insights... |
This comment has been minimized.
This comment has been minimized.
Was thinking BeautifulSoup4 4.6.0 was causing the issue, but pinning doesn't seem to help. |
This comment has been minimized.
This comment has been minimized.
I have not been able to debug this issue; lxml is installed, and that
same environment works for me locally!
|
This comment has been minimized.
This comment has been minimized.
Hmm, this is concerning, to say the least! I guess I vote for merging this anyway in that case...! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
jakirkham commentedJun 5, 2018
•
edited
Replace
bs4
withbeautifulsoup4
as they are the same and the former is merely an alias.This change is