Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC: Minor formatting/proofreading changes in Ch. 4 #363

Merged
merged 12 commits into from Mar 30, 2020

Conversation

rossbar
Copy link
Contributor

@rossbar rossbar commented Mar 24, 2020

Some minor edits to the text of ch. 4 from a recent runthrough. Some of the changes address minor markdown formatting blips (extra tickmarks, missing asterisks, etc.), others deal with LaTeX formatting for some inline math sections, and a few are grammatical. I tried to make the commits relatively fine-grained so individual changes can be easily reverted if necessary.

jni
jni approved these changes Mar 24, 2020
Copy link
Collaborator

@jni jni left a comment

🙏 !

@jni
Copy link
Collaborator

jni commented Mar 24, 2020

I'll wait 24h to give @stefanv a chance to comment but otherwise will merge. Thank you as always @rossbar!

@stefanv
Copy link
Collaborator

stefanv commented Mar 24, 2020

I did a quick scan and noticed some changes of meaning, so please hold off on merging until I've had a chance to review it more thoroughly.

Copy link
Collaborator

@stefanv stefanv left a comment

Looks good apart from the slight meaning change in smoothness.

Thanks very much @rossbar !

markdown/ch4.markdown Outdated Show resolved Hide resolved
markdown/ch4.markdown Outdated Show resolved Hide resolved
rossbar added 2 commits Mar 29, 2020
 * Fix hyphenation in large prime-numbers
 * Revert wording-change for FFT input smoothness from "inputs" back
   to "numbers"
Consensus for wording from review discussion.
@rossbar
Copy link
Contributor Author

rossbar commented Mar 30, 2020

Thanks for the feedback everyone!

@stefanv stefanv merged commit 527a27b into elegant-scipy:master Mar 30, 2020
1 check passed
@stefanv
Copy link
Collaborator

stefanv commented Mar 30, 2020

🚀 @rossbar

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants