GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
Already on GitHub? Sign in to your account
As seen in bnoordhuis/node-buffertools#19, depending on buffertools will cause this package to fail to install on Windows. You seem to only use it for buffertools.concat. Is there a way to do the same thing without that function?
@domenic yes, i think this is the path forward. i silently had hope that nodejs buffer would just get this method and wanted to just wait it out.
it seems like there is a pull request though to get buffertools working on windows however. would that solution work for you?
i'm also happy to take pull requests here to replace the 'concat' method with another library or its own internal implementation.
otherwise, you'll have to wait till i can find time to tackle this issue on my own.
Actually, yeah, that pull request went through a lot quicker than I anticipated!! I just successfully installed emailjs on windows, so all is well :D
awesome. then i'll go back to being lazy and just hoping buffer.concat becomes a native method one day!
Reopening since buffertools 1.0.8 is now excluded from package.json :(
opened a ticket on buffertools. waiting for them to fix it, so buffer tools can install on linux/mac/windows...
hopefully they are as fast as fixing is as they were yesterday =]
That would be nice :D
Yay, back to closed :)
@domenic got it to compile now. just need latest node/npm. woo
Is this now working? I want to put emailjs into etherpad-lite but w/ out MS Windows support this is a no go.
@johnyma22 Yes, as you can see by the closed status of the issue, emailjs is now working on Windows.
Thanks for the confirmation, there are some blogs floating around that state it isn't. I have asked the authors to update their posts.
From: Domenic Denicola [mailto:firstname.lastname@example.org]
Sent: 15 April 2012 02:59
To: John McLear
Subject: Re: [emailjs] Can you get away with not using buffertools? (#28)
Reply to this email directly or view it on GitHub:
This email and its attachments may be confidential and are intended solely for the use of the individual to whom it is addressed. Any views or opinions expressed are solely those of the author and do not necessarily represent those of the organisation from which this email originated. If you are not the intended recipient of this email and its attachments, you must take no action based upon them, nor must you copy or show them to anyone. Please contact the sender if you believe you have received this email in error. This email was sent by School Email - Safe Webmail and Hosted Email for Schools
thanks @johnyma22 , hopefully others will realize the latest version works with windows