Can you get away with not using buffertools? #28

Closed
domenic opened this Issue Apr 10, 2012 · 14 comments

Comments

Projects
None yet
3 participants
Contributor

domenic commented Apr 10, 2012

As seen in bnoordhuis/node-buffertools#19, depending on buffertools will cause this package to fail to install on Windows. You seem to only use it for buffertools.concat. Is there a way to do the same thing without that function?

Owner

eleith commented Apr 10, 2012

@domenic yes, i think this is the path forward. i silently had hope that nodejs buffer would just get this method and wanted to just wait it out.

it seems like there is a pull request though to get buffertools working on windows however. would that solution work for you?

i'm also happy to take pull requests here to replace the 'concat' method with another library or its own internal implementation.

otherwise, you'll have to wait till i can find time to tackle this issue on my own.

Contributor

domenic commented Apr 10, 2012

Actually, yeah, that pull request went through a lot quicker than I anticipated!! I just successfully installed emailjs on windows, so all is well :D

@domenic domenic closed this Apr 10, 2012

Owner

eleith commented Apr 10, 2012

awesome. then i'll go back to being lazy and just hoping buffer.concat becomes a native method one day!

@domenic domenic reopened this Apr 11, 2012

Contributor

domenic commented Apr 11, 2012

Reopening since buffertools 1.0.8 is now excluded from package.json :(

Owner

eleith commented Apr 11, 2012

opened a ticket on buffertools. waiting for them to fix it, so buffer tools can install on linux/mac/windows...

Owner

eleith commented Apr 11, 2012

hopefully they are as fast as fixing is as they were yesterday =]

Contributor

domenic commented Apr 11, 2012

That would be nice :D

Contributor

domenic commented Apr 11, 2012

Yay, back to closed :)

@domenic domenic closed this Apr 11, 2012

Owner

eleith commented Apr 11, 2012

@domenic got it to compile now. just need latest node/npm. woo

Contributor

JohnMcLear commented Apr 15, 2012

Is this now working? I want to put emailjs into etherpad-lite but w/ out MS Windows support this is a no go.

Contributor

domenic commented Apr 15, 2012

@johnyma22 Yes, as you can see by the closed status of the issue, emailjs is now working on Windows.

Contributor

JohnMcLear commented Apr 15, 2012

Thanks for the confirmation, there are some blogs floating around that state it isn't. I have asked the authors to update their posts.

-----Original Message-----
From: Domenic Denicola [mailto:reply@reply.github.com]
Sent: 15 April 2012 02:59
To: John McLear
Subject: Re: [emailjs] Can you get away with not using buffertools? (#28)

@johnyma22 Yes, as you can see by the closed status of the issue, emailjs is now working on Windows.


Reply to this email directly or view it on GitHub:
#28 (comment)
This email and its attachments may be confidential and are intended solely for the use of the individual to whom it is addressed. Any views or opinions expressed are solely those of the author and do not necessarily represent those of the organisation from which this email originated. If you are not the intended recipient of this email and its attachments, you must take no action based upon them, nor must you copy or show them to anyone. Please contact the sender if you believe you have received this email in error. This email was sent by School Email - Safe Webmail and Hosted Email for Schools

Owner

eleith commented Apr 15, 2012

thanks @johnyma22 , hopefully others will realize the latest version works with windows

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment