Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

refactor message.js remove buffertools #34

Closed
faruk opened this Issue Jun 13, 2012 · 1 comment

Comments

Projects
None yet
2 participants

faruk commented Jun 13, 2012

Hi,

emailjs is not compiling on my system because of buffertools. so i looked at your code and found, that you are using buffertools just in one line. i suggest you get rid of this dependency.

Line 346

           var buffer2 = buffertools.concat(previous, buffer);

there are errors in buffertools (node-gyp). see issue TooTallNate/node-gyp#77

Owner

eleith commented Jun 14, 2012

feel free to submit a patch.

for now that one line is valuable enough to use the well made buffertools module.

it will compile with gyp if you use the latest version of node.

@eleith eleith closed this Jun 14, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment