remove SMTP_USER and SMTP_PASSWORD globals #22

Closed
wants to merge 1 commit into
from

Projects

None yet

2 participants

@defunctzombie
Contributor

This allows having multiple smtp connections with different auth
requirements.

@defunctzombie defunctzombie make user and password part of the smtp object
This allows having multiple smtp connections with different auth
requirements.
1e70aba
@eleith
Owner
eleith commented Jan 11, 2012

@shtylman i like this feature.

however, one benefit of the older way was that SMTP_USER and SMTP_PASSWORD were not publicly exposed on the object. (it isn't much extra security, but it is my personal preference)

do you have ideas on how to support your feature but also keep the user/pass private to the object?

i'ld accept the patch without hesitation if you could do this.

@defunctzombie
Contributor

@eleith I don't really see the security issues here. The developer can hide the server objects as they see fit. Having the username and password in the object is not a problem. If you really want you can make them non enumerable, but again I think none of that is necessary in this case.

@eleith
Owner
eleith commented Jan 12, 2012

i agree with you. i don't see it as a problem, just a personal preference.

@eleith eleith closed this in cbbeb42 Jan 17, 2012
@eleith
Owner
eleith commented Jan 17, 2012

thanks for pushing this issue through.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment