Can send bbc or cc only emails. #52

Merged
merged 2 commits into from Dec 17, 2012

Conversation

Projects
None yet
2 participants
Contributor

fsrc commented Nov 9, 2012

I have not checked out the refs but it seems possible to send e-mail containing no to: address but only cc or bcc. This branch allows that.

Regards

Fredrik

@eleith eleith commented on an outdated diff Nov 13, 2012

smtp/message.js
@@ -125,7 +125,7 @@ Message.prototype =
{
callback(false, "message does not have a valid sender");
}
- if(!self.header.to)
+ if(!self.header.to && self.header.cc && self.header.bcc)
@eleith

eleith Nov 13, 2012

Owner

could you change this to be !(self.header.to || self.header.cc || self.header.bcc) just to make it easier to read/parse.

Owner

eleith commented Nov 13, 2012

reading through the RFC, it looks like as long as their is a RCTP TO, it doesn't matter if it is a to/bcc/cc field. so i think this change is good.

one minor update request for message.js, otherwise, this is simple enough...

Contributor

fsrc commented Nov 13, 2012

There you go!

Regards

Fredrik

@eleith eleith pushed a commit that referenced this pull request Dec 17, 2012

eleith Merge pull request #52 from KONDENSATOR/allow_no_to-address
Can send bbc or cc only emails.
879ef7e

@eleith eleith merged commit 879ef7e into eleith:master Dec 17, 2012

1 check passed

default The Travis build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment