Fix crash in the room list after a forced log out in background #3180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
📱 Scan the QR code below to install the build (arm64 only) for this PR. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #3180 +/- ##
========================================
Coverage 76.15% 76.15%
========================================
Files 1645 1645
Lines 38738 38738
Branches 7496 7496
========================================
Hits 29501 29501
Misses 5343 5343
Partials 3894 3894 ☔ View full report in Codecov by Sentry. |
ganfra
reviewed
Jul 15, 2024
| return try { | ||
| room(roomId) | ||
| } catch (exception: RoomListException) { | ||
| Timber.d(exception, "Failed finding room with id=$roomId.") | ||
| return null | ||
| } catch (exception: IllegalStateException) { |
There was a problem hiding this comment.
Should we just catch any exception then?
jmartinesp
force-pushed
the
fix/jme/room-list-service-crash-in-bg
branch
from
089320d
to
115f51b
Compare
jmartinesp
force-pushed
the
fix/jme/room-list-service-crash-in-bg
branch
from
115f51b
to
865de02
Compare
|
ganfra
approved these changes
Jul 16, 2024
jmartinesp
added
the
Run-Maestro
github-actions
bot
removed
the
Run-Maestro
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Content
Take into account
IllegalStateExceptiontoo when trying to retrieve a room fromRoomListService.Motivation and context
Fixes #3173, although it doesn't fix the logout that caused the crash.
Tests
I don't see an easy way to test this.
Tested devices
Checklist