From abcad059542d71fbd44671766388e1af3c79776f Mon Sep 17 00:00:00 2001 From: JeremyWuuuuu <15975785+JeremyWuuuuu@users.noreply.github.com> Date: Sat, 22 Oct 2022 12:44:06 +0800 Subject: [PATCH] refactor(components): [carousel] * Extract component logic out of .vue file. * Reorganize code for better readability. --- packages/components/carousel/src/carousel.ts | 3 - packages/components/carousel/src/carousel.vue | 272 ++--------------- packages/components/carousel/src/instance.ts | 3 + .../components/carousel/src/use-carousel.ts | 276 ++++++++++++++++++ 4 files changed, 302 insertions(+), 252 deletions(-) create mode 100644 packages/components/carousel/src/instance.ts create mode 100644 packages/components/carousel/src/use-carousel.ts diff --git a/packages/components/carousel/src/carousel.ts b/packages/components/carousel/src/carousel.ts index 1d659472bd1cac..89213bd5d7ae32 100644 --- a/packages/components/carousel/src/carousel.ts +++ b/packages/components/carousel/src/carousel.ts @@ -1,6 +1,5 @@ import { buildProps, isNumber } from '@element-plus/utils' import type { ExtractPropTypes } from 'vue' -import type Carousel from './carousel.vue' export const carouselProps = buildProps({ initialIndex: { @@ -64,5 +63,3 @@ export const carouselEmits = { export type CarouselProps = ExtractPropTypes export type CarouselEmits = typeof carouselEmits - -export type CarouselInstance = InstanceType diff --git a/packages/components/carousel/src/carousel.vue b/packages/components/carousel/src/carousel.vue index ab9047fbda5490..44138ecf6f51d4 100644 --- a/packages/components/carousel/src/carousel.vue +++ b/packages/components/carousel/src/carousel.vue @@ -62,60 +62,39 @@