Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(hooks): [use-popper] #10983

Merged
merged 9 commits into from Dec 19, 2022
Merged

feat(hooks): [use-popper] #10983

merged 9 commits into from Dec 19, 2022

Conversation

jw-foss
Copy link
Member

@jw-foss jw-foss commented Dec 14, 2022

The current popper is coupled with the UI, this PR brings two benefits:

  1. Propose a new way for our users to use popper without additional features so and extra code for their own implementation of tooltips or popovers.
  2. Also, this could reduce the complexity of the code, meaning better readability.

Please make sure these boxes are checked before submitting your PR, thank you!

  • Make sure you follow contributing guide English | (中文 | Español | Français).
  • Make sure you are merging your commits to dev branch.
  • Add some descriptions and refer to relative issues for your PR.

@github-actions
Copy link

github-actions bot commented Dec 14, 2022 •
edited

@github-actions github-actions bot added the CommitMessage::Qualified Qualified commit message label Dec 14, 2022
@github-actions
Copy link

github-actions bot commented Dec 14, 2022 •
edited

🧪 Playground Preview: https://element-plus.run/?pr=10983
Please comment the example via this playground if needed.

@jw-foss
feat(hooks): [use-popper]
78f44a7 
* Implement use-popper
@jw-foss jw-foss force-pushed the feat/use-popper branch 2 times, most recently from f2f3373 to a5ab93d Compare December 15, 2022 14:33
chenxch
chenxch reviewed Dec 15, 2022
View reviewed changes
packages/hooks/use-popper/index.ts Outdated Show resolved Hide resolved
packages/hooks/use-popper/index.ts Outdated Show resolved Hide resolved
packages/hooks/use-popper/index.ts Outdated Show resolved Hide resolved
packages/hooks/use-popper/index.ts Outdated Show resolved Hide resolved
packages/hooks/use-popper/index.ts Show resolved Hide resolved
@jw-foss jw-foss changed the title [🚧 WIP] feat(hooks): [use-popper] feat(hooks): [use-popper] Dec 16, 2022
@jw-foss jw-foss requested a review from chenxch December 19, 2022 12:43
chenxch
chenxch approved these changes Dec 19, 2022
View reviewed changes
Copy link
Member

@chenxch chenxch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have no further questions about this from my side at the moment.

@jw-foss jw-foss merged commit ec161ea into dev Dec 19, 2022
10 checks passed
@jw-foss jw-foss deleted the feat/use-popper branch December 19, 2022 13:46
@element-bot element-bot mentioned this pull request Dec 30, 2022
Merged
3 tasks
@acyza acyza mentioned this pull request Feb 18, 2023
Merged
3 tasks
loosheng pushed a commit to loosheng/element-plus that referenced this pull request Mar 26, 2023
@jw-foss @loosheng
feat(hooks): [use-popper] (element-plus#10983)
c96b8f5 
* feat(hooks): [use-popper]

* Implement use-popper

* chore: code adjustment

* test: add test for use popper

* test: finish test for use popper

* fix: popper API

* chore: remove unused imports

* chore: refine code

* feat: export popper from hooks package

* chore: enhanced how to process default value

Co-authored-by: JeremyWuuuuu <15975785+JeremyWuuuuu@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chenxch chenxch chenxch approved these changes

Assignees

@jw-foss jw-foss

Labels
CommitMessage::Qualified Qualified commit message
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jw-foss @chenxch