Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(components): [table] overflow tooltip supports enterable and customization #10984

Merged
merged 6 commits into from Dec 22, 2022

Conversation

plainheart
Copy link
Member

@plainheart plainheart commented Dec 15, 2022

Please make sure these boxes are checked before submitting your PR, thank you!

  • Make sure you follow contributing guide English | (中文 | Español | Français).
  • Make sure you are merging your commits to dev branch.
  • Add some descriptions and refer to relative issues for your PR.

Resolves issues

Related PRs

Changes

  1. Add tooltip-options prop for ElTable to allow global configuration

  2. The show-overflow-tooltip prop of ElTableColumn now accepts an object (the same as tooltip-options above) as the value

  3. The overflow tooltip supports enterable and enabled by default

  4. Removed the outdated prop show-tooltip-when-overflow

👉 ▶ Playground

@github-actions
Copy link

github-actions bot commented Dec 15, 2022

@github-actions github-actions bot added the CommitMessage::Qualified Qualified commit message label Dec 15, 2022
@github-actions
Copy link

github-actions bot commented Dec 15, 2022

🧪 Playground Preview: https://element-plus.run/?pr=10984
Please comment the example via this playground if needed.

@plainheart plainheart marked this pull request as draft December 15, 2022 06:28
@plainheart plainheart marked this pull request as ready for review December 15, 2022 07:19
Copy link
Member

@chenxch chenxch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome~👍With the support of tooltipOptions, our form is more powerful.

It would be nice if this was reflected in the documentation, perhaps adding some test cases.

packages/components/table/src/util.ts Outdated Show resolved Hide resolved
@chenxch
Copy link
Member

chenxch commented Dec 15, 2022

/cc @element-plus/backers

@plainheart plainheart merged commit cf58472 into dev Dec 22, 2022
10 checks passed
@plainheart plainheart deleted the feat/table/tooltip-enterable branch December 22, 2022 04:20
@element-bot element-bot mentioned this pull request Dec 30, 2022
3 tasks
loosheng pushed a commit to loosheng/element-plus that referenced this pull request Mar 26, 2023
…ustomization (element-plus#10984)

* feat(components): [table] overflow tooltip supports `enterable`

* fix(components): [table] fix modifiers merge

* fix(components): [table] refine logic & fix popperClass isn't respected

* docs(components): [table] add docs for `tooltip-options` & `show-overflow-tooltip`

* docs(components): [table]

* docs(components): [table] update version tag

Co-authored-by: Xc <124118265@qq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment