Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(components): [cascader] use script-setup syntax #11013

Merged
merged 7 commits into from Dec 20, 2022
Merged

refactor(components): [cascader] use script-setup syntax #11013

merged 7 commits into from Dec 20, 2022

Conversation

chenxch
Copy link
Member

@chenxch chenxch commented Dec 17, 2022

Please make sure these boxes are checked before submitting your PR, thank you!

  • Make sure you follow contributing guide English | (中文 | Español | Français).
  • Make sure you are merging your commits to dev branch.
  • Add some descriptions and refer to relative issues for your PR.

@github-actions
Copy link

github-actions bot commented Dec 17, 2022 •
edited

@github-actions github-actions bot added the CommitMessage::Qualified Qualified commit message label Dec 17, 2022
@github-actions
Copy link

github-actions bot commented Dec 17, 2022 •
edited

🧪 Playground Preview: https://element-plus.run/?pr=11013
Please comment the example via this playground if needed.

holazz
holazz reviewed Dec 18, 2022
View reviewed changes
packages/components/cascader/src/cascader.ts Outdated Show resolved Hide resolved
packages/components/cascader/src/cascader.ts Outdated Show resolved Hide resolved
packages/components/cascader/src/cascader.ts Outdated Show resolved Hide resolved
packages/components/cascader/src/cascader.ts Outdated Show resolved Hide resolved
@chenxch chenxch mentioned this pull request Dec 20, 2022
Merged
3 tasks
@holazz holazz merged commit 8af1128 into dev Dec 20, 2022
10 checks passed
@holazz holazz deleted the refactor/cascader-setup-syntax branch December 20, 2022 02:56
@element-bot element-bot mentioned this pull request Dec 30, 2022
Merged
3 tasks
loosheng pushed a commit to loosheng/element-plus that referenced this pull request Mar 26, 2023
@chenxch @loosheng
refactor(components): [cascader] use script-setup syntax (element-plu…
7c5babb 
…s#11013)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryuhangyeong ryuhangyeong ryuhangyeong left review comments

@holazz holazz holazz approved these changes

Assignees

@chenxch chenxch

Labels
CommitMessage::Qualified Qualified commit message
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@chenxch @holazz @ryuhangyeong