Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(components): [input-number] fix args order #11020

Merged
merged 1 commit into from Dec 20, 2022
Merged

fix(components): [input-number] fix args order #11020

merged 1 commit into from Dec 20, 2022

Conversation

sleepyShen1989
Copy link
Contributor

closed #11015

input-number中change事件的参数顺序与文档中不一致

Please make sure these boxes are checked before submitting your PR, thank you!

  • Make sure you follow contributing guide English | (中文 | Español | Français).
  • Make sure you are merging your commits to dev branch.
  • Add some descriptions and refer to relative issues for your PR.

@pull-request-triage
Copy link

👋 @sleepyShen1989, seems like this is your first time contribution to element-plus.

  • Please make sure that you have read our guidelines and code of conduct before making a contribution.
  • You can comment with /label Components:[component_name] to add a label for which component you are working on.
  • You may join our Discord for staying tuned.

@pull-request-triage pull-request-triage bot added 1st contribution Their very first contribution Needs Review labels Dec 18, 2022
@github-actions
Copy link

Hello @sleepyShen1989, thank you for contributing to element-plus, please see our guideline to see how to make contribution

@github-actions
Copy link

github-actions bot commented Dec 18, 2022 •
edited

@sleepyShen1989 sleepyShen1989 changed the title fix(components): edit args order fix(components): [input-number] edit args order Dec 18, 2022
@sleepyShen1989 sleepyShen1989 changed the title fix(components): [input-number] edit args order fix(components): [input-number] fix args order Dec 18, 2022
@github-actions github-actions bot added the CommitMessage::Qualified Qualified commit message label Dec 18, 2022
@github-actions
Copy link

🧪 Playground Preview: https://element-plus.run/?pr=11020
Please comment the example via this playground if needed.

@holazz holazz merged commit 930dd4f into element-plus:dev Dec 20, 2022
12 checks passed
@sleepyShen1989 sleepyShen1989 deleted the fix/input-number-args-order branch December 20, 2022 13:57
@element-bot element-bot mentioned this pull request Dec 30, 2022
Merged
3 tasks
loosheng pushed a commit to loosheng/element-plus that referenced this pull request Mar 26, 2023
@sleepyShen1989 @loosheng
fix(components): [input-number] fix args order (element-plus#11020)
6381a46 
closed element-plus#11015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@holazz holazz holazz approved these changes

@btea btea btea approved these changes

Assignees

@sleepyShen1989 sleepyShen1989

Labels
1st contribution Their very first contribution CommitMessage::Qualified Qualified commit message Contribution::Community Needs Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[TypeScript] [input-number] onChange 参数与预期相反
3 participants
@sleepyShen1989 @holazz @btea