Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(docs): some wrong examples in the document #11072

Merged
merged 2 commits into from Dec 28, 2022
Merged

fix(docs): some wrong examples in the document #11072

merged 2 commits into from Dec 28, 2022

Conversation

liunnn1994
Copy link
Contributor

Please make sure these boxes are checked before submitting your PR, thank you!

  • Make sure you follow contributing guide English | (中文 | Español | Français).
  • Make sure you are merging your commits to dev branch.
  • Add some descriptions and refer to relative issues for your PR.
  1. Update deprecated attributes in the drawer component example
  2. Fix wrong types in tree component examples

@pull-request-triage
Copy link

👋 @asdjgfr, thank you for contributing element-plus.

  • You can comment with /label Components:[component_name] to add a label for which component you are working on.
  • You may join our Discord for staying tuned.

@github-actions
Copy link

Hello @asdjgfr, thank you for contributing to element-plus, please see our guideline to see how to make contribution

@github-actions
Copy link

github-actions bot commented Dec 26, 2022 •
edited

@github-actions github-actions bot added the CommitMessage::Qualified Qualified commit message label Dec 26, 2022
@github-actions
Copy link

github-actions bot commented Dec 26, 2022 •
edited

🧪 Playground Preview: https://element-plus.run/?pr=11072
Please comment the example via this playground if needed.

@chenxch
Copy link
Member

chenxch commented Dec 28, 2022 •
edited

@asdjgfr I don't know if it's a problem with online viewing, the document seems to be unformatted, please help to confirm whether pnpm run lint:fix has been executed

@liunnn1994
Copy link
Contributor Author

@asdjgfr I don't know if it's a problem with online viewing, the document seems to be unformatted, please help to confirm whether pnpm run lint:fix has been executed

image
image

I have already run lint:fix, and no problems occurred locally.

@chenxch
Copy link
Member

chenxch commented Dec 28, 2022

I have already run lint:fix, and no problems occurred locally.

Thanks for your confirmation.

chenxch
chenxch approved these changes Dec 28, 2022
View reviewed changes
Copy link
Member

@chenxch chenxch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@chenxch chenxch changed the title Fix some wrong examples in the document fix(docs): some wrong examples in the document Dec 28, 2022
@btea btea merged commit 751ec37 into element-plus:dev Dec 28, 2022
10 checks passed
@element-bot element-bot mentioned this pull request Dec 30, 2022
Merged
3 tasks
loosheng pushed a commit to loosheng/element-plus that referenced this pull request Mar 26, 2023
@liunnn1994 @loosheng
fix(docs): some wrong examples in the document (element-plus#11072)
1828d72 
* docs(docs): fix wrong types in examples

* docs(docs): update deprecated attributes in the example
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chenxch chenxch chenxch approved these changes

@btea btea btea approved these changes

Assignees

@liunnn1994 liunnn1994

Labels
CommitMessage::Qualified Qualified commit message Contribution::Community Needs Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@liunnn1994 @chenxch @btea