Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(components): [date-picker] not trigger emits when type is monthrange #13880

Closed
wants to merge 7 commits into from
Closed

fix(components): [date-picker] not trigger emits when type is monthrange #13880

wants to merge 7 commits into from

Conversation

listennn08
Copy link

@listennn08 listennn08 commented Aug 5, 2023 •
edited
Loading

Please make sure these boxes are checked before submitting your PR, thank you!

  • Make sure you follow contributing guide English | (中文 | Español | Français).
  • Make sure you are merging your commits to dev branch.
  • Add some descriptions and refer to relative issues for your PR.

Description

fix the date picker didn't trigger emits calendar-change when type is monthrange
closed #13835

🤖 Generated by Copilot at dc2bdf6

Emit calendar-change event from panel-month-range.vue to sync month range selection with parent component. This enables custom month range feature in date picker.

Related Issue

Fixes #___.

Explanation of Changes

🤖 Generated by Copilot at dc2bdf6

  • Emit calendar-change event with selected month range in panel (link)

@listennn08
fix(components): [date-picker] not trigger emits when type is monthrange
dc2bdf6 
fix the date picker didn't trigger emits `calendar-change` when type is monthrange

closed element-plus#13835
@pull-request-triage
Copy link

👋 @listennn08, seems like this is your first time contribution to element-plus.

  • Please make sure that you have read our guidelines and code of conduct before making a contribution.
  • You can comment with /label Components:[component_name] to add a label for which component you are working on.
  • You may join our Discord for staying tuned.

@pull-request-triage pull-request-triage bot added 1st contribution Their very first contribution Needs Review labels Aug 5, 2023
@github-actions
Copy link

github-actions bot commented Aug 5, 2023

Hello @listennn08, thank you for contributing to element-plus, please see our guideline to see how to make contribution

@github-actions
Copy link

github-actions bot commented Aug 5, 2023 •
edited
Loading

@xdbobname
Copy link

@btea could you take a look? I really need it, THANKS VERY MUCH!

@github-actions github-actions bot added the CommitMessage::Qualified Qualified commit message label Sep 7, 2023
@github-actions
Copy link

github-actions bot commented Sep 7, 2023

🧪 Playground Preview: https://element-plus.run/?pr=13880
Please comment the example via this playground if needed.

@Justineo Justineo mentioned this pull request Sep 12, 2023
Merged
3 tasks
@listennn08 listennn08 closed this Sep 13, 2023
@listennn08 listennn08 deleted the fix/fix-calendar-change-not-working-in-monthrange branch September 14, 2023 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tolking tolking tolking left review comments

@xdbobname xdbobname xdbobname left review comments

@btea btea btea approved these changes

@ryuhangyeong ryuhangyeong ryuhangyeong approved these changes

Assignees

@listennn08 listennn08

Labels
1st contribution Their very first contribution CommitMessage::Qualified Qualified commit message Contribution::Community Needs Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Component] [date-picker] Datepicker did not trigger calendar-change when type is monthrange
5 participants
@listennn08 @xdbobname @tolking @btea @ryuhangyeong