Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cjg/ci docs #213

Merged
merged 2 commits into from Nov 7, 2019

Conversation

@Cody-G
Copy link
Contributor

Cody-G commented Nov 7, 2019

Closes #189.

This required me to remove the .circleci folder from atom's .dockerignore, not sure if this will build correctly. May need to make a separate PR for that and merge it first.

(and I'll rebase this as needed with the other PRs landing)

@Cody-G

This comment has been minimized.

Copy link
Contributor Author

Cody-G commented Nov 7, 2019

Looks like I do indeed need to make a separate PR to remove .circleci from .dockerignore in atom. Otherwise the docs can't build. @dpipemazo do you agree this is the way to go?

@Cody-G Cody-G force-pushed the cjg/ci_docs branch from 3b7aeef to dd86a12 Nov 7, 2019
@Cody-G

This comment has been minimized.

Copy link
Contributor Author

Cody-G commented Nov 7, 2019

Requires #216

@dpipemazo dpipemazo merged commit aded928 into master Nov 7, 2019
2 checks passed
2 checks passed
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: docs Your tests passed on CircleCI!
Details
@dpipemazo dpipemazo deleted the cjg/ci_docs branch Nov 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.