Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for fwupd #123

Closed
ma1onso opened this issue Oct 9, 2017 · 12 comments · Fixed by #150
Closed

Add support for fwupd #123

ma1onso opened this issue Oct 9, 2017 · 12 comments · Fixed by #150

Comments

@ma1onso
Copy link
Sponsor

ma1onso commented Oct 9, 2017

Example:
h3wxye1

https://fwupd.org/

@fabianthoma fabianthoma self-assigned this Dec 29, 2017
@danirabbit danirabbit changed the title Add support for fwupd Add support for fwupd [$50] Jan 7, 2018
@cassidyjames
Copy link
Contributor

@fabianthoma are you still planning on tackling this?

@danirabbit
Copy link
Member

Gonna punt this feature since we're already end of April

@cassidyjames cassidyjames changed the title Add support for fwupd [$50] Add support for fwupd [$100] Jun 13, 2018
@cassidyjames
Copy link
Contributor

cassidyjames commented Jun 28, 2019

Thinking about this again design-wise and consent-wise. I don't know that we want to put anything in onboarding (it's not relevant to the whole OS, just AppCenter). Instead, would an infobar in the Installed pane be okay? Something like:

AppCenter can use a secure web service to update device and component firmware Privacy Policy Enable

image

var fwupd_info_label = new Gtk.Label (_("AppCenter can use a secure web service to update device and component firmware"));
fwupd_info_label.show ();

var fwupd_infobar = new Gtk.InfoBar ();
fwupd_infobar.message_type = Gtk.MessageType.INFO;
fwupd_infobar.visible = true;

fwupd_infobar.get_content_area ().add (fwupd_info_label);

var fwupd_privacy_button = new Gtk.LinkButton.with_label ("https://fwupd.org/privacy", _("Privacy Policy"));
fwupd_infobar.add_action_widget (fwupd_privacy_button, 0);

var fwupd_enable_button = fwupd_infobar.add_button (_("Enable"), 0);
action_button_group.add_widget (fwupd_enable_button);

Then enabling that would enable fwupd to check for updates and whatnot. @danrabbit thoughts on the design, and @elementary/desktop-developers do you know how feasible that would be?

@cassidyjames
Copy link
Contributor

I guess something we need to consider: dismissing/declining to use fwupd. 😛

@mmstick
Copy link

mmstick commented Jun 28, 2019

For what it's worth, the plan for Pop!_OS is to integrate fwupd support via a new firmware panel in GNOME Settings > Devices.

@hughsie
Copy link

hughsie commented Jun 29, 2019

If it helps, Andrew is a Dell intern who's building a standalone power-user firmware install application: https://gitlab.gnome.org/hughsie/gnome-firmware-updater

@jackpot51
Copy link

To add to @mmstick, I don't think our plan for fwupd in Pop!_OS conflicts with the plan to add fwupd to AppCenter. We would just not enable fwupd in AppCenter and have our GNOME Settings panel handle it.

@jackpot51
Copy link

@hughsie I think elementary will need a Vala wrapper for libfwupd to accomplish this - or they would use the org.freedesktop.fwupd DBUS API directly.

@hughsie
Copy link

hughsie commented Jul 1, 2019

I think in GUI apps using the D-Bus interface async is the correct thing to use; libfwupd is really a very thin wrapper around that. If Vala bindings for any of the convenience API (like for instance fwupd/fwupd#1232 ) then we can easily add that.

@danirabbit
Copy link
Member

@cassidyjames I think opt-in makes sense here.

I wonder if we should make it more clear in the messaging that the service is "3rd party" or "non-curated"? Would it be inaccurate to say something to the effect of "manufacturer provided firmware updates"? I think that what we want to inform the user of here is probably two things:

  1. There is some data collection that happens when you opt in here
  2. These updates are provided by some other entity than elementary.

And yeah adding a button like "Don't Ask Again" or something makes sense to be able to dismiss this permanently

@hughsie
Copy link

hughsie commented Jul 1, 2019

Would it be inaccurate to say something to the effect of "manufacturer provided firmware updates

I think that's accurate, the firmware itself is being provided by the OEMs but to a central "silo" managed by a shared service supported by the Linux Foundation.

@cassidyjames
Copy link
Contributor

Moving to About plug since that's probably where firmware (and eventually OS upgrades) make more sense to manage. Still wondering about what actually checks for updates in the background (since AppCenter already has a daemon), how we throw notifications i.e. for critical updates, etc.

Something we should figure out, but I do think the UI at least does make sense in Switchboard.

@cassidyjames cassidyjames transferred this issue from elementary/appcenter Jun 22, 2020
@cassidyjames cassidyjames added this to To do in 6.0 Odin Release via automation Jun 22, 2020
@cassidyjames cassidyjames added this to To do in OEM-friendliness via automation Dec 10, 2020
@cassidyjames cassidyjames moved this from To do to In progress in OEM-friendliness Dec 10, 2020
@cassidyjames cassidyjames moved this from To do to In progress in 6.0 Odin Release Dec 10, 2020
@cassidyjames cassidyjames changed the title Add support for fwupd [$100] Add support for fwupd Jan 19, 2021
@danirabbit danirabbit removed this from In progress in 6.0 Odin Release Jan 22, 2021
OEM-friendliness automation moved this from In progress to Done Jan 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging a pull request may close this issue.

7 participants