New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

meson regression: contract directory no longer installed #26

Open
decathorpe opened this Issue Aug 2, 2018 · 2 comments

Comments

Projects
None yet
2 participants
@decathorpe
Copy link

decathorpe commented Aug 2, 2018

The meson equivalent of install (DIRECTORY DESTINATION ${CMAKE_INSTALL_FULL_DATAROOTDIR}/contractor) is missing - so the contracts directory is no longer created upon installation.

@CameronNemo

This comment has been minimized.

Copy link
Contributor

CameronNemo commented Oct 4, 2018

Can't this be handled by packaging? In Void an empty directory will be removed without some packaging hooks anyway.

@decathorpe

This comment has been minimized.

Copy link

decathorpe commented Oct 4, 2018

@CameronNemo I am handling this in packaging now.

It's just best practice on fedora to have the main package own the directory structure it provides for its "children". In this case, contractor expects other packages to put their contracts in this directory, so contractor should create the directory and the contractor package should own it.

This has the nice benefit that - when removing contractor and all contracts - everything is cleaned up nicely, and no empty directories are left behind, cluttering the system.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment