Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support the settings portal where is possible #529

Merged
merged 2 commits into from Oct 6, 2021

Conversation

Marukesu
Copy link
Contributor

blocked by elementary/settings-daemon#38

This make the functions that read some setting provided by the portal to try it first, allowing we get the right values when sandboxed.

Allows granite to use the host settings when running sandboxed
@jhaygood86
Copy link
Contributor

Can you look at merging this with #528 ?

I don't think you need a new Portal Settings class, the existing Settings class is probably fine.

@Marukesu
Copy link
Contributor Author

Can you look at merging this with #528 ?

I think #528 is out of scope for this PR, since this aren't adding a new API, but just making the current functions use the portal. However i can rebase it on top of #527.

I don't think you need a new Portal Settings class, the existing Settings class is probably fine.

I made it this way so that we declare the interface (and any other interface we need) just in one place.

Copy link
Member

@danirabbit danirabbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, let's go 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants