Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt to the latest Mutter API #377

Merged
merged 2 commits into from Nov 12, 2019
Merged

Conversation

@worldofpeace
Copy link
Contributor

worldofpeace commented Oct 30, 2019

I've tested that it builds with mutter 3.34.1 and 3.28.4.
What I've done in SystemBackground.vala is probably totally incorrect. A suggestion is welcome on what we actually should be doing.

What I've done is adapted the changes in elementary/gala#566, as it's literally the code copy pasted mostly, to be used here.

Fixes #120.

It would be fabulous ✌️ if we could have everything adapted to latest mutter before the end of the year.

@worldofpeace worldofpeace force-pushed the worldofpeace:mutter-3.3x branch from 2c84215 to d15adff Oct 30, 2019
@Tireg

This comment has been minimized.

Copy link
Contributor

Tireg commented Nov 8, 2019

Ok now I can confirm this works great since May 8, when I dropped the first patch (#120 (comment)).
Didn't encountered any issue from this time with greeter.
@worldofpeace has done a great work by adding this PR and adapting changes for newer mutter versions.

This would be great to have some review here as everything seems to work as expected.

@worldofpeace

This comment has been minimized.

Copy link
Contributor Author

worldofpeace commented Nov 11, 2019

Ok now I can confirm this works great since May 8, when I dropped the first patch (#120 (comment)).
Didn't encountered any issue from this time with greeter.
@worldofpeace has done a great work by adding this PR and adapting changes for newer mutter versions.

This would be great to have some review here as everything seems to work as expected.

Thanks @Tireg, also thanks for tracking down all the issues so carefully in gala.
It's pretty important to me as a downstream to be able to support latest mutter API's and not hold compatibility packages.

@tintou tintou force-pushed the worldofpeace:mutter-3.3x branch from b3c1051 to 1cd5528 Nov 12, 2019
@tintou tintou dismissed their stale review via 32b0581 Nov 12, 2019
@tintou tintou force-pushed the worldofpeace:mutter-3.3x branch from 1cd5528 to 32b0581 Nov 12, 2019
@worldofpeace

This comment has been minimized.

Copy link
Contributor Author

worldofpeace commented Nov 12, 2019

@tintou I did notice that the background with mutter 3.34 never got drawn...

@worldofpeace

This comment has been minimized.

Copy link
Contributor Author

worldofpeace commented Nov 12, 2019

Will quote that

What I've done in SystemBackground.vala is probably totally incorrect. A suggestion is welcome on what we actually should be doing.

I believe there's something going on there.

@tintou tintou dismissed their stale review via b073510 Nov 12, 2019
@tintou tintou force-pushed the worldofpeace:mutter-3.3x branch 2 times, most recently from b073510 to 5011b53 Nov 12, 2019
@tintou

This comment has been minimized.

Copy link
Collaborator

tintou commented Nov 12, 2019

@worldofpeace I just pushed a fix to this, It was because system_background.set_wallpaper (); wasn't called in the 3.34 version, I fixed it by setting the system wallpaper at object construction as it is done in Gala

@tintou tintou force-pushed the worldofpeace:mutter-3.3x branch from 5011b53 to 61eb966 Nov 12, 2019
@tintou tintou force-pushed the worldofpeace:mutter-3.3x branch from 61eb966 to 7554842 Nov 12, 2019
@tintou
tintou approved these changes Nov 12, 2019
@worldofpeace

This comment has been minimized.

Copy link
Contributor Author

worldofpeace commented Nov 12, 2019

@worldofpeace I just pushed a fix to this, It was because system_background.set_wallpaper (); wasn't called in the 3.34 version, I fixed it by setting the system wallpaper at object construction as it is done in Gala

Thanks

@tintou tintou merged commit 15c80e4 into elementary:master Nov 12, 2019
2 checks passed
2 checks passed
build
Details
lint
Details
@tintou

This comment has been minimized.

Copy link
Collaborator

tintou commented Nov 12, 2019

Thank you :)

@worldofpeace worldofpeace deleted the worldofpeace:mutter-3.3x branch Nov 12, 2019
@worldofpeace

This comment has been minimized.

Copy link
Contributor Author

worldofpeace commented Nov 12, 2019

I'm not sure if elementary/gala#518 will also be present in the greeter. But if any fix makes its way there it probably should be ported here too.

@Tireg Tireg mentioned this pull request Nov 13, 2019
2 of 3 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.