Repository navigation
New feature: Editing a CalDAV account - #216
Merged
Merged
Conversation
Member
Author
|
Fixes #201 |
danirabbit
previously approved these changes
Dec 9, 2021
danirabbit
left a comment
danirabbit
left a comment
Member
There was a problem hiding this comment.
Sorry for taking so long to review here! I can confirm this works as intended. Nice job handling all the different success/failure states!
danirabbit
approved these changes
Dec 9, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Similar approach as in #208.
Please note: In case of editing I was unable to remove just the child sources since EDS claims the remote does not allow calendars to be deleted. Since this is not what we want anyways, I simply delete the collection source (which is the "main" account source) and re-create a fresh one with the fetched calendars as new children.