Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nextcloud Provider Support #121

Draft
wants to merge 2 commits into
base: master
from

Conversation

@marbetschar
Copy link

marbetschar commented Jan 27, 2020

Draft pull request for Nextcloud support in Online Accounts. Next steps to consider:

  • WIP: User needs the possibility to enter the Nextcloud server url before we try to login with OAuth
  • The Integration.vala needs to be modified to whatever the Nextcloud OAuth flow expects
  • The Nextcloud services Tasks, Calendars and Contacts need to be properly configured (what are the allowed BackendNames?)
@marbetschar marbetschar changed the title Provider files for Nextcloud added Nextcloud Provider Support Jan 27, 2020
@danrabbit danrabbit requested a review from tintou Jan 27, 2020
@danrabbit danrabbit added this to To Do in Nextcloud Support via automation Jan 27, 2020
@danrabbit danrabbit moved this from To Do to In Progress in Nextcloud Support Jan 27, 2020
@marbetschar

This comment has been minimized.

Copy link
Author

marbetschar commented Jan 28, 2020

Since we are using the Nextcloud Desktop Client's OAuth Client ID and Secret, I asked for clarification if dedicated keys for elementary OS should be created: https://help.nextcloud.com/t/how-to-request-a-well-known-oauth-client-id-and-secret-for-elementary-os/69469

@marbetschar

This comment has been minimized.

Copy link
Author

marbetschar commented Jan 29, 2020

@tintou can you please advise if the following works?

The goal is to allow a user to enter a Nextcloud server URL and use this user defined URL in the subsequent OAuth authentication flow:

  1. Add <setting name="AskNextcloudURL" type="boolean">true</setting> node as first chlid node within <group name="oauth2"> of the nextcloud.provider.in file
  2. Define OnlineAccounts.Key.ASK_NEXTCLOUD_URL in src/Authentification/Key.vala
  3. Create src/Authentification/NextcloudURLDialog.vala based on MailDialog.vala
  4. Add else if (info.parameters.contains (OnlineAccounts.Key.ASK_NEXTCLOUD_URL)) in src/Authentification/RequestQueue.vala
…l something seems missing.
@marbetschar

This comment has been minimized.

Copy link
Author

marbetschar commented Jan 30, 2020

tested my assumptions in code - does not work as expected, the NextcloudDialog is not shown. @tintou what I'm missing here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Nextcloud Support
  
In Progress
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant
You can’t perform that action at this time.