Skip to content

Made sure we always set the due date to the next full hour if not def… - #102

Merged
danirabbit merged 6 commits into
masterfrom
due-next-hour
Oct 6, 2020
Merged

danirabbit merged 6 commits into
masterfrom
due-next-hour

Conversation

@marbetschar

@marbetschar marbetschar commented Apr 6, 2020 •

Copy link
Copy Markdown
Member

ready for review

…ined otherwise. This fixes #96.

@marbetschar
marbetschar requested a review from danirabbit April 6, 2020 21:12
@marbetschar
marbetschar requested a review from tintou April 11, 2020 18:11

@danirabbit danirabbit left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if we should move that default due DateTime outside the conditional since we use it in both halves

Comment thread src/Widgets/TaskRow.vala Outdated
@marbetschar
marbetschar requested a review from danirabbit October 5, 2020 17:13

@danirabbit danirabbit left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable :)

@danirabbit
danirabbit merged commit 9a0cc2f into master Oct 6, 2020
@danirabbit
danirabbit deleted the due-next-hour branch October 6, 2020 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Set due date to next full hour

2 participants