Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #16 #17

Merged
merged 3 commits into from Aug 9, 2019

Conversation

@alainm23
Copy link
Contributor

commented Aug 8, 2019

image

@danrabbit
Copy link
Member

left a comment

Thanks for the branch! I'm fine with doing things this way :) Couple little nitpicks:

src/ListView.vala Outdated Show resolved Hide resolved
src/Widgets/ListSettingsPopover.vala Outdated Show resolved Hide resolved
@danrabbit
Copy link
Member

left a comment

Nice! This is looking good. Just one more tiny nitpicky comment and then I think we're good to merge :)

src/Widgets/ListSettingsPopover.vala Outdated Show resolved Hide resolved
@danrabbit
Copy link
Member

left a comment

Nice work. Lookin' good!

@danrabbit danrabbit merged commit 081390f into elementary:master Aug 9, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.