New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reverse phrasing for the paste dialog checkbox #294

Closed
cassidyjames opened this Issue Sep 18, 2018 · 7 comments

Comments

Projects
None yet
5 participants
@cassidyjames
Member

cassidyjames commented Sep 18, 2018

Right now it's "Do not show this dialog again" which ends up being weirdly negative. Instead, we could reverse the meaning of the checkbox and have it be "Show paste protection warnings" or something, and have it checked by default.

@cassidyjames

This comment has been minimized.

Member

cassidyjames commented Oct 6, 2018

For reference, this is what we did with the similar explicit content warning dialog in AppCenter.

@wolfshirts

This comment has been minimized.

wolfshirts commented Oct 7, 2018

I'm having a really hard time getting my changes to build.

git clone $repo
make changes
git commit $path_to_changed_file -m "some message"
meson build --prefix=/src
cd build
ninja test

Everything works, changes are included. I make more changes, commit them, run ninja, and everything is back to the original source I pulled. I don't really know meson/ninja very well, but google is failing to answer my questions, anyone have any ideas?

@jeremypw

This comment has been minimized.

Contributor

jeremypw commented Oct 8, 2018

@wolfshirts

This is what I do:

After cloning the repo you should be on the master branch.
Navigate to the local root of the repo and make sure it compiles with meson build --prefix=/usr && cd build && ninja (you may have to install build dependencies). You will end up in the build directory. If the build fails just type ninja to restart the build after fixing it, or to force a complete recompile use cd .. && sudo rm -R ./build && meson build --prefix=/usr && cd build && ninja.

Then make a new branch and check it out with git checkout -b name-of-new-branch. Make your changes to this branch. Compile them using ninja or to force a complete recompile use cd .. && sudo rm -R ./build && meson build --prefix=/usr && cd build && ninja.

Run locally with ./io.elementary.terminal . Some changes may need installing with sudo ninja install first to take effect, after which use io.elementary.terminal to run the installed version.

Commit the changes to the new branch either with git commit -am "commit-message" (assuming you want any and all newly created files added to the branch). You may find it easier to install the git-gui package and then use git gui to start the gui interface to see what changes have been made and to control which will be committed.

To save your changes to GitHub use git push and copy the instruction that git suggests to create the upstream branch, then after that you can just use git push to upload further committed changes.

When you are ready you can create a PR from this upstream branch using GitHub. GitHub will use Travis/Houston CI to check your new branch passes various tests. It will also check for conflicts with the master branch, if it has been updated, which you will need to fix. Either fix them online and pull the changes down to your local branch or merge your updated local master branch in to the new branch locally and after fixing the conflicts push the changes back upstream.

If you change a translatable string then the translation may not be present and you will see the untranslated English version instead until the po files have been updated. There is a string freeze at the moment until Juno release, I believe.

I hope this helps.

@wolfshirts

This comment has been minimized.

wolfshirts commented Oct 8, 2018

Followed the directions, ended up accidentally setting up a pull request. I'm still unable to see my changes to my local repo when I build with meson, even after deleting ./build. Here's what it looks like.
peek 2018-10-08 11-31
The result of my changes and build.
screenshot from 2018-10-08 11 32 49
This text by the checkbox should read "changed"

@cassidyjames

This comment has been minimized.

Member

cassidyjames commented Oct 8, 2018

@wolfshirts since Terminal is still open in your screencast, you're just opening another instance of the already running process. You need to close the running Terminal first.

@wolfshirts

This comment has been minimized.

wolfshirts commented Oct 8, 2018

Thanks a ton. This fixed it for me. Didn't realize that was the default behavior.

@ls42

This comment has been minimized.

Contributor

ls42 commented Oct 8, 2018

I'm also working on this, and what I've been doing is:

  • Set up a VM with elementaryOS
  • Set up SSH with X11Forwarding
  • Set up dev environment (Sublime Text for me) and edit the source in the VM with a forwarded editor
  • Run the build and run terminal from the command line. It will also run over the forwarded X11 and pop up on my local screen.

This way I can keep local terminals open at the same time as the terminals I'm currently editing.

ls42 added a commit to ls42/terminal that referenced this issue Oct 8, 2018

ls42 added a commit to ls42/terminal that referenced this issue Oct 9, 2018

@danrabbit danrabbit added this to the 5.3.3 milestone Nov 16, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment