Added open source information and fixed ampersands #1583
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cassidyjames
suggested changes
Feb 14, 2017
open-source.php
Outdated
| @@ -15,7 +15,24 @@ | |||
| <div class="two-thirds"> | |||
| <h1>We're Built on Open Source</h1> | |||
| <h4>The elementary OS platform is built upon a strong foundation of Free & Open Source software. Without projects such as these, elementary OS would not exist.</h4> | |||
| </div> | |||
| <div class="half"> | |||
| <h3>Security & Privacy</h3> | |||
There was a problem hiding this comment.
Indentation looks off starting here. Our code style is 4 spaces.
open-source.php
Outdated
| <h4>By being Open Source, elementary OS can benefit from superior security and privacy over closed source software. When the source code is available to audit, anyone in the community — whether a security researcher, a concerned user, or an OEM shipping the OS on their hardware — can ensure the software is secure and not collecting or leaking personal information.</h4> | ||
| </div> | ||
| <div class="half"> | ||
| <div> |
There was a problem hiding this comment.
Extra wrapper div in here?
|
The ampersand changes and copy itself look good, just some indentation weirdness I think. |
Not sure what happened with my editor, but this should be good.
cassidyjames
suggested changes
Feb 14, 2017
open-source.php
Outdated
| </div> | ||
| <div class="half"> | ||
| <h3>Security & Privacy</h3> | ||
| <h4>By being Open Source, elementary OS can benefit from superior security and privacy over closed source software. When the source code is available to audit, anyone in the community — whether a security researcher, a concerned user, or an OEM shipping the OS on their hardware — can ensure the software is secure and not collecting or leaking personal information.</h4> |
open-source.php
Outdated
| </div> | ||
| <div class="half"> | ||
| <h3>Better for Developers</h3> | ||
| <h4>If your app could benefit from a system API or feature that’s not yet available, you can help write that feature into the OS. Similarly, you might be curious as to how a feature or design pattern in elementary OS was made. Instead of guessing or trying to reimplement it on your own, you can just look at the underlying source code for a definitive answer.</h4> |
open-source.php
Outdated
| <a class="button suggested-action" href="get-involved#desktop-development">Get Involved</a> | ||
| <div class="whole"> | ||
| <div class="two-thirds"> | ||
| <h2>We Support Open Source Projects</h2> |
There was a problem hiding this comment.
It looks like this block got copied in up here when it's already down below.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1269
Changes Summary
This pull request [ is ] ready for review.