Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion - Use "selector" only when needed in Custom CSS, not forced #1086

Closed
pingram3541 opened this issue Dec 24, 2016 · 5 comments
Closed

Suggestion - Use "selector" only when needed in Custom CSS, not forced #1086

pingram3541 opened this issue Dec 24, 2016 · 5 comments

Comments

@pingram3541
Copy link
Contributor

@pingram3541 pingram3541 commented Dec 24, 2016

Currently when using the Pro Custom CSS feature we are restricted to css for that element and child selectors only. We can't apply hierarchical rules such as "body.is-special .some-elementor-selector a" For example, adding custom css to a text element like so:

a {
  color: blue;
}

results in:

.unique-elementor-selector-class a {
  color: blue;
}

However we can already do this using "selector" to achieve the same result:

selector a {
  color: blue;
}

So why not remove the forced inclusion and allow us full freedom to write our own rules, media queries, @font rules and most importantly body class selectors so we can truly refine our designs without leaving the designer?

This way if we have full control without sacrificing the simplicity of using custom because we still have the dynamic "selector" variable.

Yes we can do this with tools outside Elementor, but that's not what we want. =)

@pingram3541
Copy link
Contributor Author

@pingram3541 pingram3541 commented Dec 24, 2016

Another use case I just came across is when the design calls for absolute positioned elements I'd like to add rules such as:

body:not(.elementor-editor-active) .elementor-selector-section {
  position: absolute;
  ...
}

or:

body:not(.logged-in) .elementor-selector-section {
  position: absolute;
  ...
}

This way I get the desired results on the front end but do not break Elementor's inline editor controls mixed into the page content when editing.

@arielk
Copy link
Contributor

@arielk arielk commented Dec 24, 2016

Your right, we are going to improve this feature in the next version of E-pro..

@pingram3541
Copy link
Contributor Author

@pingram3541 pingram3541 commented Dec 24, 2016

Awesome, thanks for continuing to make this plugin amazing!

@arielk
Copy link
Contributor

@arielk arielk commented Dec 27, 2016

We released v1.0.5 please update and get it :)

@arielk arielk closed this Dec 27, 2016
@drawcard
Copy link
Contributor

@drawcard drawcard commented Dec 28, 2016

Legendary! Thank you for doing this work over the holiday break too...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants