Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gutenberg blocks .alignleft .alignright broken by Elementor #11906

Closed
borayeris opened this issue Jul 21, 2020 · 2 comments
Closed

Gutenberg blocks .alignleft .alignright broken by Elementor #11906

borayeris opened this issue Jul 21, 2020 · 2 comments
Labels
compatibility/3rd-party Indicates a compatibility problem with a 3rd-party plugin or theme. status/merged Indicates when a Pull Request has been merged to a Release.
Milestone
3.0.0

Comments

@borayeris
Copy link

Prerequisites

  • [ x ] I have searched for similar issues in both open and closed tickets and cannot find a duplicate.
  • [ x ] The issue still exists against the latest stable version of Elementor.

Description

The following line of code clashes with WP's default align styles, as referenced in Elementor Hello theme:
.elementor .elementor-widget:not(.elementor-widget-text-editor) figure {
margin: 0; }

Steps to reproduce

Open a post and add an image. Align it left. Write a long paragraph to wrap it. There is no margin between the image and the text.

Isolating the problem

  • [ x ] This bug happens with only Elementor plugin active (and Elementor Pro).
  • [ x ] This bug happens with a default WordPress theme active.
  • [ x ] I can reproduce this bug consistently using the steps above.

Environment

System Info ``` ```
@arielk arielk added compatibility/3rd-party Indicates a compatibility problem with a 3rd-party plugin or theme. status/has-pr Indicates that an Issue, or Discussion has a companion Pull Request awaiting to be merged. labels Jul 30, 2020
@arielk arielk added this to the 3.0.0 milestone Jul 30, 2020
@arielk
Copy link
Contributor

arielk commented Jul 31, 2020

Ref: #7331

KingYes added a commit that referenced this issue Aug 2, 2020
@KingYes
Merge pull request #11998 from arielk/fix/image-block-style
0444310 
Fix: image block alignment broken by Elementor close #11906
@shilo-ey shilo-ey mentioned this issue Aug 3, 2020
Closed
@shilo-ey shilo-ey added status/merged Indicates when a Pull Request has been merged to a Release. and removed status/has-pr Indicates that an Issue, or Discussion has a companion Pull Request awaiting to be merged. labels Aug 3, 2020
@shilo-ey
Copy link
Contributor

This issue has been resolved in Elementor v3.0

Feel free to update

Thanks!

kobizz added a commit to kobizz/elementor that referenced this issue Aug 31, 2020
@kobizz
Merge branch 'release/3.0.0' of github.com:elementor/elementor into f…
4f824c1 
…eature/import-export

* 'release/3.0.0' of github.com:elementor/elementor: (142 commits)
  Core/Upgrades: Fix -  Move saved colors to kit: 'Color #i' => 'Saved Color #i'.
  Kit/Design System: Fix - On delete item the CSS is not affected.
  Tests/PHPUnit: Fix - Data mock controller.
  Kits: Fix - Kit settings are not initialized properly.
  Global CSS: Fix - Page title margins are missing.
  Bump 3.0.0-beta3
  Admin Settings: Advanced - Legacy Mode - Tweaked text strings.
  Media Carousel: Fix - Media Carousel opens wrong video in lightbox.
  Fixed editing handles aren't updated until you refresh the page
  Fix: image block alignment broken by Elementor close elementor#11906
  Site Settings: Save Toaster - adjust the routing hooks so that when clicking "Back to Editor", it will open on the last place the user was in before entering the kit settings.
  Modules : Screenshots - Remove - Screenshotshot (moved to pro).
  Site Settings: Show Toaster when Site Settings (=Kit settings) are saved.
  Theme Builder: Fix - Template display level select arrow disappears in dark mode.
  Global Control Popover: CSS tweaks.
  Globals: New Global Modal - Make the controlled input callback agnostic to the global type.
  Global Control Popover: Gave a class to the span element in the popover header.
  Update data/base/controller.php
  Module : Screenshots - Change - Remove screenshots tests.
  Module : Screenshots - Change - Remove the screenshot from the editor.
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
compatibility/3rd-party Indicates a compatibility problem with a 3rd-party plugin or theme. status/merged Indicates when a Pull Request has been merged to a Release.
Projects
None yet
Milestone
3.0.0
Development

No branches or pull requests
3 participants
@arielk @borayeris @shilo-ey