Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove default 20px margin below Elementor Widgets #1221

Closed
katart opened this issue Jan 25, 2017 · 11 comments

Comments

Projects
None yet
8 participants
@katart
Copy link

commented Jan 25, 2017

All Elementor Widgets seem to have a default 20px bottom margin and there doesn't seem to be a way to override this in the Elementor Widget settings. This is the CSS code that affects the Elementor widgets:

.elementor-widget:not(:last-child) { margin-bottom: 20px; }

I would like to remove this 20px margin without editing the CSS. Is this possible?

@pingram3541

This comment has been minimized.

Copy link
Contributor

commented Feb 8, 2017

I just want to add that I understand the need to have this default margin for those that would be simply using the widgets "as-is" and not need to worry about white space above/below widgets but there should be a way to remove this without having to use custom css...especially with how selectors can change with future updates breaking that custom css.

I propose a simple checkbox that would remove any default container margins that way it can be done without breaking tons of installs and we can choose to do this only on specific elements and the default remains in tact for the rest.

@mjflower

This comment has been minimized.

Copy link

commented May 7, 2017

Great idea. +1

@pingram3541

This comment has been minimized.

Copy link
Contributor

commented May 7, 2017

Yes, don't remove it, just allow us to disable it when it applies and then it doesn't break any sites going backwards =)

@bmwillrath

This comment has been minimized.

Copy link

commented Jun 9, 2017

+1

@tudormnt

This comment has been minimized.

Copy link

commented Jun 9, 2017

Definitely a big + for not having this as default. As design patterns go, there is a need to add margin to some elements but adding this for a widgets (which bundle more than one base html element) is a incorrect. I'm thinking that a control to space out widgets at the column level (like spacing anything in Elementor, really) is the way to go, instead of having to disable this.

@soyket

This comment has been minimized.

Copy link

commented Jun 10, 2017

agreed !

@arielk arielk added this to the 1.5.0 milestone Jun 11, 2017

kobizz added a commit to kobizz/elementor that referenced this issue Jun 11, 2017

@arielk

This comment has been minimized.

Copy link
Contributor

commented Jun 20, 2017

Elementor 1.5 RC2 has already been released with this enhancement, please check this issue #1827

Thanks for the feedback!

@arielk arielk closed this Jun 20, 2017

@leocrespo

This comment has been minimized.

Copy link

commented Apr 13, 2019

Where can I find this setting to disable the default margin-bottom? I know it has been released on 1.5 RC2 but where it is?

@pingram3541

This comment has been minimized.

Copy link
Contributor

commented Apr 15, 2019

@leocrespo It can be found in each column's layout tab under Widget's Space (px):

Screen Shot 2019-04-15 at 4 36 18 PM

...and in the Global Settings found using the upper-left nav menu icon (3 bars) or within Elementor's back end settings.

Screen Shot 2019-04-15 at 4 36 41 PM

Screen Shot 2019-04-15 at 4 36 58 PM

@leocrespo

This comment has been minimized.

Copy link

commented Apr 17, 2019

@pingram3541

This comment has been minimized.

Copy link
Contributor

commented Apr 18, 2019

Yep, you've found a bug. (tested v2.5.14)

  • Editing a column's settings and adding any value in the "Widget's Space" field results in the update button turning green and when clicked successfully saving.

- Going to Global Settings and adding any value in the "Widget's Space" field results in the update button NOT turning green nor is it clickable to update the settings.

...however, on second review, it actually uses ajax to automatically update when changing focus away form that field. (note green progress bar at top of screen that may go by quickly and not be noticed)

If I then edit something else, forcing the update button to turn green and click update, it saves and even when refreshing the page I can see the global setting is also saved. Checking the back end settings as well (/wp-admin/admin.php?page=elementor#tab-style) I can see my value is also stored there. So you can get around this but it's a little bit tricky.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.