Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Page Settings can't be saved (v1.4.0) #1546

Closed
agusmu opened this Issue Mar 28, 2017 · 10 comments

Comments

Projects
None yet
5 participants
@agusmu
Copy link

agusmu commented Mar 28, 2017

Description

Page Settings can't be saved, especially background styles when we edit page settings only, without editing any existing elements on editor.

Steps to reproduce

Case 1 (OK, page settings can be saved)

  1. Edit existing elementor page
  2. Edit background styles on page settings
  3. Edit any existing element on editor
  4. Click save button

Case 2 (NOT OK, page settings can not be saved)

  1. Edit existing elementor page
  2. Edit background styles on page settings
    (Do not edit any existing element on editor)
  3. Click save button

Note

I can see that when you edit any existing element, the save editor button changes to "green".

But when you edit page settings ONLY, the save editor button doesn't change to "green".

@kobizz

This comment has been minimized.

Copy link
Contributor

kobizz commented Mar 29, 2017

Page settings are saved automatically. You don't need to click the save button for saving the settings.

kobizz added a commit to kobizz/elementor that referenced this issue Mar 29, 2017

KingYes added a commit that referenced this issue Mar 29, 2017

Merge pull request #1548 from cobicarmel/release/1.4.1
Save settings on each change after 3 sec. #1546.

@arielk arielk added the bug label Mar 29, 2017

@ramiy

This comment has been minimized.

Copy link
Contributor

ramiy commented Apr 2, 2017

@cobicarmel @arielk
the changes are saved on the data base but the user don't see the changes being updated on the page. For some people it's very confusing. I hear complains too.

I think the best solution is to add an "update changes to page" BUTTON like the one you have on the Shortcode Widget. This will force Elementor to update the preview with updated content.

update-changes

It's also a good solution for dynamic widgets like the widgets in my "Press Elements" plugin that display post elements.

When updating post fields from the elementor "Page Settings" pannel, the data is not updated on the page. With the new button to update changes to page will resolve all the issues.

@ryanlabelle

This comment has been minimized.

Copy link

ryanlabelle commented Apr 2, 2017

@ramiy Thank you. So the button would invoke a "save changes" and also previewReload()? and this would be in the page settings panel?

That would be amazing!

@ramiy

This comment has been minimized.

Copy link
Contributor

ramiy commented Apr 2, 2017

Amazing and very intuitive for non-techy users!

@ryanlabelle

This comment has been minimized.

Copy link

ryanlabelle commented Apr 2, 2017

It's been a real pleasure working with Elementor from the frontend to the api. Your team is adding great new features. I'm very pleased to see you making it developer friendly too.

@arielk

This comment has been minimized.

Copy link
Contributor

arielk commented Apr 3, 2017

This issue has been resolved in b1.4.1 by auto-save every 3 sec. please update.

@arielk arielk closed this Apr 3, 2017

@ryanlabelle

This comment has been minimized.

Copy link

ryanlabelle commented Apr 3, 2017

Thank you. I needed it to refresh the preview as well so I tapped into the onchange event.

#1556 (comment)

@ramiy

This comment has been minimized.

Copy link
Contributor

ramiy commented Apr 4, 2017

@arielk It saves the data on the server every 3 sec, but it doesn't update the Elementor preview screen. Press Elements widgets display the old title.

@kobizz

This comment has been minimized.

Copy link
Contributor

kobizz commented Apr 4, 2017

@ryanlabelle

This comment has been minimized.

Copy link

ryanlabelle commented Apr 4, 2017

Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.