Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

latin-ext subset for google fonts #1630

Closed
meande opened this issue Apr 24, 2017 · 3 comments

Comments

Projects
None yet
5 participants
@meande
Copy link

commented Apr 24, 2017

In Czech we use characters like "ščřž..." that are not embeded in standard "latin" subset in google fonts.

So if I use Open Sans font in my headlines and elementor only embeds "latin" subset, all of the "ščřž..." characters are replaced with system sans-serif font and it looks ugly.

There are already cyrillic, hebrew, greek and vietnamese subsets in print_google_fonts() function in includes/frontend.php. Is it possible to add one more line 'cs_CZ' => 'latin-ext', to the $subsets array, so it looks like this?

$subsets = [
'ru_RU' => 'cyrillic',
'bg_BG' => 'cyrillic',
'he_IL' => 'hebrew',
'el' => 'greek',
'vi' => 'vietnamese',
'uk' => 'cyrillic',
'cs_CZ' => 'latin-ext',
];

arielk added a commit to arielk/elementor that referenced this issue Apr 25, 2017

@arielk arielk added this to the 1.5.0 milestone Apr 25, 2017

@KingYes

This comment has been minimized.

Copy link
Member

commented May 3, 2017

We will release this on v1.5.0. Thanks!

@KingYes KingYes closed this May 3, 2017

@meande

This comment has been minimized.

Copy link
Author

commented May 3, 2017

You are the best! Thank you :)

@dudaster

This comment has been minimized.

Copy link

commented Jun 29, 2017

The same must be done for Romanian
Please add:
'ro_RO' => 'latin-ext',

It's working on most of the browsers without latin-ext, but for some reason in microsoft edge browser needs this latin-ext.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.