Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

latin-ext subset for google fonts #1630

Closed
meande opened this issue Apr 24, 2017 · 11 comments
Closed

latin-ext subset for google fonts #1630

meande opened this issue Apr 24, 2017 · 11 comments

Comments

@meande
Copy link

@meande meande commented Apr 24, 2017

In Czech we use characters like "ščřž..." that are not embeded in standard "latin" subset in google fonts.

So if I use Open Sans font in my headlines and elementor only embeds "latin" subset, all of the "ščřž..." characters are replaced with system sans-serif font and it looks ugly.

There are already cyrillic, hebrew, greek and vietnamese subsets in print_google_fonts() function in includes/frontend.php. Is it possible to add one more line 'cs_CZ' => 'latin-ext', to the $subsets array, so it looks like this?

$subsets = [
'ru_RU' => 'cyrillic',
'bg_BG' => 'cyrillic',
'he_IL' => 'hebrew',
'el' => 'greek',
'vi' => 'vietnamese',
'uk' => 'cyrillic',
'cs_CZ' => 'latin-ext',
];

arielk added a commit to arielk/elementor that referenced this issue Apr 25, 2017
@arielk arielk added this to the 1.5.0 milestone Apr 25, 2017
@KingYes
Copy link
Member

@KingYes KingYes commented May 3, 2017

We will release this on v1.5.0. Thanks!

@KingYes KingYes closed this May 3, 2017
@meande
Copy link
Author

@meande meande commented May 3, 2017

You are the best! Thank you :)

@dudaster
Copy link

@dudaster dudaster commented Jun 29, 2017

The same must be done for Romanian
Please add:
'ro_RO' => 'latin-ext',

It's working on most of the browsers without latin-ext, but for some reason in microsoft edge browser needs this latin-ext.

Thanks!

@vinkoprelac
Copy link

@vinkoprelac vinkoprelac commented Aug 17, 2019

It should be also added for Croatian
'hr_HR' => 'latin-ext',

And also for the following languages, but I'm not sure about the correct locale codes (this is per https://stackoverflow.com/a/28357857):

Serbian
sr_Latn: "Serbian (Latin)",
sr_Latn_BA: "Serbian (Latin, Bosnia and Herzegovina)",
sr_Latn_ME: "Serbian (Latin, Montenegro)",
sr_Latn_RS: "Serbian (Latin, Serbia)",

Slovenian
sl_SI: "Slovenian (Slovenia)",
sl: "Slovenian",

Bosnian
bs_BA: "Bosnian (Bosnia and Herzegovina)",
bs: "Bosnian"

@sztivoo
Copy link

@sztivoo sztivoo commented Sep 7, 2019

Please make the same for Hungarian

Please add:
'hu_HU' => 'latin-ext',

@andrejm
Copy link

@andrejm andrejm commented Nov 22, 2019

... aaaand 'sk_SK' => 'latin-ext', for Slovakia would be also very appreciated :)

Or possibly a filter hook for subsets?

@ogio
Copy link

@ogio ogio commented Mar 15, 2020

Any update regarding implementation of google font subsets?

@vsosp16
Copy link

@vsosp16 vsosp16 commented May 9, 2020

This line must be added too for Turkish. We always need the latin-extended.
'tr_TR' => 'latin-ext',

@shilo-ey
Copy link
Collaborator

@shilo-ey shilo-ey commented Aug 26, 2020

This issue has been resolved in Elementor v3.0

Feel free to update

Thanks!

@skorenjak
Copy link

@skorenjak skorenjak commented Apr 22, 2021

I have Elementor v3.1.4 and the issue with Slovenian ('sl_SI' => 'latin-ext',) persists. Is there a setting I'm missing?

@martinsober
Copy link

@martinsober martinsober commented Oct 11, 2021

I have Elementor v3.1.4 and the issue with Slovenian ('sl_SI' => 'latin-ext',) persists. Is there a setting I'm missing?

Still no fix for Slovenian. Pretty dissapointing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet