Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

An issue with "Image Widget" custom sizes #1688

Closed
ramiy opened this issue May 6, 2017 · 1 comment

Comments

Projects
None yet
3 participants
@ramiy
Copy link
Contributor

commented May 6, 2017

Description

When you set custom image sizes on "Image Widget", and you enter only the width or the only the height, you get a PHP notice.

PHP Notices

Missing width notice:

[06-May-2017 13:48:48 UTC] PHP Notice: Undefined offset: 0 in C:\xampp\htdocs\elementor\wp-content\plugins\elementor\includes\libraries\bfi-thumb\bfi-thumb.php on line 792

[06-May-2017 13:48:48 UTC] PHP Notice: Undefined offset: 0 in C:\xampp\htdocs\elementor\wp-content\plugins\elementor\includes\libraries\bfi-thumb\bfi-thumb.php on line 797

Missing height notice:

[06-May-2017 13:51:41 UTC] PHP Notice: Undefined offset: 1 in C:\xampp\htdocs\elementor\wp-content\plugins\elementor\includes\libraries\bfi-thumb\bfi-thumb.php on line 793

[06-May-2017 13:51:41 UTC] PHP Notice: Undefined offset: 1 in C:\xampp\htdocs\elementor\wp-content\plugins\elementor\includes\libraries\bfi-thumb\bfi-thumb.php on line 797

Steps to reproduce

  1. turn on your debug log.
  2. Drag a new "Image Widget" to any section.
  3. Select a "Custom" image size.
  4. Set only the image "Width", no "Height".
  5. Save the page and view the page on your front-end.
  6. Now check out the log.

Environment

  • WordPress 4.7.4
  • Elementor 1.4.5

Screenshot

image-widget-error

@KingYes KingYes self-assigned this May 7, 2017

@KingYes KingYes added the bug label May 7, 2017

@KingYes KingYes added this to the 1.5.0 milestone May 7, 2017

@KingYes KingYes modified the milestones: 1.4.6, 1.5.0 May 7, 2017

@KingYes

This comment has been minimized.

Copy link
Member

commented May 7, 2017

Thanks!

@arielk arielk removed this from the 1.4.6 milestone May 9, 2017

@KingYes KingYes closed this in 17bcd2f May 9, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.